src/utils/SkLua.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkLua.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Android fix + nit fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkLua.cpp

diff --git a/src/utils/SkLua.cpp b/src/utils/SkLua.cpp

index 4409e477e56d1fd37b02e464b292a50f2b7c9b1a..98880d0154788501df0295da494409414e43dec8 100644

--- a/src/utils/SkLua.cpp

+++ b/src/utils/SkLua.cpp

@@ -2049,7 +2049,7 @@ static int lsk_newTypeface(lua_State* L) {

}

- sk_sp<SkTypeface> face(SkTypeface::MakeFromName(name, (SkTypeface::Style)style));

+ sk_sp<SkTypeface> face(SkTypeface::MakeFromName(name, SkFontStyle::FromOldStyle(style)));

// SkDebugf("---- name <%s> style=%d, face=%p ref=%d\n", name, style, face, face->getRefCnt());

if (nullptr == face) {

face = SkTypeface::MakeDefault();

« no previous file with comments | « src/fonts/SkTestScalerContext.h ('k') | src/utils/SkWhitelistTypefaces.cpp » ('j') | no next file with comments »