dm/DM.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DM.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Android fix + nit fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DM.cpp

diff --git a/dm/DM.cpp b/dm/DM.cpp

index f29726e04c7f8db93b89079cedf81ea1e7f321a3..2dbd1ca5d3112658d6d9d26c96cd8ac640ea829c 100644

--- a/dm/DM.cpp

+++ b/dm/DM.cpp

@@ -1219,7 +1219,7 @@ SkThread* start_status_thread() {

#define PORTABLE_FONT_PREFIX "Toy Liberation "

-static sk_sp<SkTypeface> create_from_name(const char familyName[], SkTypeface::Style style) {

+static sk_sp<SkTypeface> create_from_name(const char familyName[], SkFontStyle style) {

if (familyName && strlen(familyName) > sizeof(PORTABLE_FONT_PREFIX)

&& !strncmp(familyName, PORTABLE_FONT_PREFIX, sizeof(PORTABLE_FONT_PREFIX) - 1)) {

return sk_tool_utils::create_portable_typeface(familyName, style);

@@ -1229,7 +1229,7 @@ static sk_sp<SkTypeface> create_from_name(const char familyName[], SkTypeface::S

#undef PORTABLE_FONT_PREFIX

-extern sk_sp<SkTypeface> (*gCreateTypefaceDelegate)(const char [], SkTypeface::Style );

+extern sk_sp<SkTypeface> (*gCreateTypefaceDelegate)(const char [], SkFontStyle );

int dm_main();

int dm_main() {

« no previous file with comments | « bench/TextBlobBench.cpp ('k') | fuzz/FilterFuzz.cpp » ('j') | no next file with comments »