tests/PictureTest.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1126)

My Issues | Starred Open | Closed | All

Unified Diff: tests/PictureTest.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Compile fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« gm/fontcache.cpp ('K') | « tests/PDFPrimitivesTest.cpp ('k') | tests/TypefaceTest.cpp » ('j') | tests/TypefaceTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index c71e66309aa71cde7b567276950fdf306c582fba..3dcdcfcf2713f592f831a03d004ae4a2bc748238 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -1116,7 +1116,8 @@ static void test_typeface(skiatest::Reporter* reporter) {

SkPictureRecorder recorder;

SkCanvas* canvas = recorder.beginRecording(10, 10);

SkPaint paint;

- paint.setTypeface(SkTypeface::MakeFromName("Arial", SkTypeface::kItalic));

+ paint.setTypeface(SkTypeface::MakeFromName("Arial",

+ SkFontStyle::FromOldStyle(SkTypeface::kItalic)));

canvas->drawText("Q", 1, 0, 10, paint);

sk_sp<SkPicture> picture(recorder.finishRecordingAsPicture());

SkDynamicMemoryWStream stream;

« gm/fontcache.cpp ('K') | « tests/PDFPrimitivesTest.cpp ('k') | tests/TypefaceTest.cpp » ('j') | tests/TypefaceTest.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698