tests/FontObjTest.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(475)

My Issues | Starred Open | Closed | All

Unified Diff: tests/FontObjTest.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Compile fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« gm/fontcache.cpp ('K') | « tests/FontMgrTest.cpp ('k') | tests/PDFPrimitivesTest.cpp » ('j') | tests/TypefaceTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/FontObjTest.cpp

diff --git a/tests/FontObjTest.cpp b/tests/FontObjTest.cpp

index 66c8bd500f3c8a409666ad191b0489085ab2bb7e..44f799ece185a43849832568fce7eccfba5936cb 100644

--- a/tests/FontObjTest.cpp

+++ b/tests/FontObjTest.cpp

@@ -78,7 +78,7 @@ static void test_cachedfont(skiatest::Reporter* reporter) {

char txt[] = "long.text.with.lots.of.dots.";

for (size_t i = 0; i < SK_ARRAY_COUNT(faces); i++) {

- paint.setTypeface(SkTypeface::MakeFromName(faces[i], SkTypeface::kNormal));

+ paint.setTypeface(SkTypeface::MakeFromName(faces[i], SkFontStyle()));

for (size_t j = 0; j < SK_ARRAY_COUNT(settings); j++) {

paint.setHinting(settings[j].hinting);

« gm/fontcache.cpp ('K') | « tests/FontMgrTest.cpp ('k') | tests/PDFPrimitivesTest.cpp » ('j') | tests/TypefaceTest.cpp » ('J')

Powered by Google App Engine

This is Rietveld 408576698