src/ports/SkFontHost_win.cpp - Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkFontHost_win.cpp

Issue 1818043002: SkTypeface::MakeFromName to take SkFontStyle. (Closed) Base URL: https://chromium.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkFontHost_win.cpp

diff --git a/src/ports/SkFontHost_win.cpp b/src/ports/SkFontHost_win.cpp

index 10476ad4345f509073fd3a62d05cf176d891d95a..69fd79b42ab419c559014cc2285712016f7bb705 100644

--- a/src/ports/SkFontHost_win.cpp

+++ b/src/ports/SkFontHost_win.cpp

@@ -120,6 +120,7 @@ static void dcfontname_to_skstring(HDC deviceContext, const LOGFONT& lf, SkStrin

static void make_canonical(LOGFONT* lf) {

lf->lfHeight = -64;

+ lf->lfWidth = 0;

bungeman-skia 2016/03/21 16:14:26 This seems wrong. Why is it here?

lf->lfQuality = CLEARTYPE_QUALITY;//PROOF_QUALITY;

lf->lfCharSet = DEFAULT_CHARSET;

// lf->lfClipPrecision = 64;

« include/core/SkTypeface.h ('K') | « src/core/SkTypeface.cpp ('k') | no next file » | no next file with comments »