Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Side by Side Diff: chrome/browser/media/webrtc_video_quality_browsertest.cc

Issue 1817983002: Remove tests using the default codec (i.e. VP8) from chrome_webrtc_perf_browsertest.cc and chrome_w… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/media/webrtc_perf_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/environment.h" 9 #include "base/environment.h"
10 #include "base/files/file.h" 10 #include "base/files/file.h"
(...skipping 340 matching lines...) Expand 10 before | Expand all | Expand 10 after
351 scoped_ptr<base::Environment> environment_; 351 scoped_ptr<base::Environment> environment_;
352 base::FilePath webrtc_reference_video_y4m_; 352 base::FilePath webrtc_reference_video_y4m_;
353 base::ScopedTempDir temp_working_dir_; 353 base::ScopedTempDir temp_working_dir_;
354 }; 354 };
355 355
356 INSTANTIATE_TEST_CASE_P( 356 INSTANTIATE_TEST_CASE_P(
357 WebRtcVideoQualityBrowserTests, 357 WebRtcVideoQualityBrowserTests,
358 WebRtcVideoQualityBrowserTest, 358 WebRtcVideoQualityBrowserTest,
359 testing::ValuesIn(kVideoConfigurations)); 359 testing::ValuesIn(kVideoConfigurations));
360 360
361 // The video codec name is now appended to the test label (e.g. '720p_VP8').
362 // TODO(asapersson): Keep test below using the default video codec (which do
363 // not have the codec name appended ('720p')) until new tests have been
364 // running for some time.
365 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
366 MANUAL_TestVideoQualityDefault) {
367 TestVideoQuality("");
368 }
369
370 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 361 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
371 MANUAL_TestVideoQualityVp8) { 362 MANUAL_TestVideoQualityVp8) {
372 TestVideoQuality("VP8"); 363 TestVideoQuality("VP8");
373 } 364 }
374 365
375 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 366 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
376 MANUAL_TestVideoQualityVp9) { 367 MANUAL_TestVideoQualityVp9) {
377 TestVideoQuality("VP9"); 368 TestVideoQuality("VP9");
378 } 369 }
379 370
380 #if BUILDFLAG(RTC_USE_H264) 371 #if BUILDFLAG(RTC_USE_H264)
381 372
382 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest, 373 IN_PROC_BROWSER_TEST_P(WebRtcVideoQualityBrowserTest,
383 MANUAL_TestVideoQualityH264) { 374 MANUAL_TestVideoQualityH264) {
384 // Only run test if run-time feature corresponding to |rtc_use_h264| is on. 375 // Only run test if run-time feature corresponding to |rtc_use_h264| is on.
385 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) { 376 if (!base::FeatureList::IsEnabled(content::kWebRtcH264WithOpenH264FFmpeg)) {
386 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. " 377 LOG(WARNING) << "Run-time feature WebRTC-H264WithOpenH264FFmpeg disabled. "
387 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 " 378 "Skipping WebRtcVideoQualityBrowserTest.MANUAL_TestVideoQualityH264 "
388 "(test \"OK\")"; 379 "(test \"OK\")";
389 return; 380 return;
390 } 381 }
391 TestVideoQuality("H264"); 382 TestVideoQuality("H264");
392 } 383 }
393 384
394 #endif // BUILDFLAG(RTC_USE_H264) 385 #endif // BUILDFLAG(RTC_USE_H264)
OLDNEW
« no previous file with comments | « chrome/browser/media/webrtc_perf_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698