Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 1817963003: Fix a warning about inline asm source/destination mismatches for cache_type_register_. (Closed)

Created:
4 years, 9 months ago by echristo.google
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix a warning about inline asm source/destination mismatches for cache_type_register_. The warning notes that we'd want a 'w' register here because the size of the operand is 32-bit, however, the instruction only takes an 'x' register and so force that using the 'x' modifier on the instruction. BUG= Committed: https://crrev.com/d6d82306978d9878366b68e8e6c20b8965db4f94 Cr-Commit-Position: refs/heads/master@{#35008}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/arm64/cpu-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
echristo.google
Original patch was reverted as part of reverting a much larger patch that moved this ...
4 years, 9 months ago (2016-03-21 18:28:42 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-22 13:50:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817963003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817963003/1
4 years, 9 months ago (2016-03-22 21:26:49 UTC) #6
echristo.google
Thanks!
4 years, 9 months ago (2016-03-22 21:27:04 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 21:47:43 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 21:48:42 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6d82306978d9878366b68e8e6c20b8965db4f94
Cr-Commit-Position: refs/heads/master@{#35008}

Powered by Google App Engine
This is Rietveld 408576698