Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1817913003: Turn StoreWithInterceptor into a turbofan stub (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn StoreWithInterceptor into a turbofan stub BUG= Committed: https://crrev.com/75ed4a6071a4a2561136173882c8f48432d5c2cd Cr-Commit-Position: refs/heads/master@{#34927}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -116 lines) Patch
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 3 chunks +13 lines, -1 line 0 comments Download
M src/code-stubs.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-21 08:19:41 UTC) #2
Benedikt Meurer
LGTM. https://codereview.chromium.org/1817913003/diff/1/src/code-stubs.h File src/code-stubs.h (right): https://codereview.chromium.org/1817913003/diff/1/src/code-stubs.h#newcode781 src/code-stubs.h:781: class StoreInterceptorStub : public TurboFanCodeStub { Doesn't this ...
4 years, 9 months ago (2016-03-21 09:22:30 UTC) #3
Toon Verwaest
Addressed, thanks.
4 years, 9 months ago (2016-03-21 09:41:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817913003/20001
4 years, 9 months ago (2016-03-21 09:41:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 10:25:34 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 10:26:54 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/75ed4a6071a4a2561136173882c8f48432d5c2cd
Cr-Commit-Position: refs/heads/master@{#34927}

Powered by Google App Engine
This is Rietveld 408576698