Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 18179009: Introduce unregisterProtocolHandler() and isProtocolHandlerRegistered() webview API (Closed)

Created:
7 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce unregisterProtocolHandler() and isProtocolHandlerRegistered() webview API As a step to support the custom scheme handler in experimental features, this cl introduce unregisterProtocolHandler() and isProtocolHandlerRegistered(). The content module will be able to deregister existing registered protocol and check if a protocol is registered. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165276

Patch Set 1 #

Patch Set 2 : Work in progress 2 #

Patch Set 3 : Work in progress 3 #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M Source/web/AssertMatchingEnums.cpp View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 3 1 chunk +2 lines, -3 lines 0 comments Download
A + public/web/WebNavigatorContentUtilsClient.h View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
M public/web/WebViewClient.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
gyuyoung-inactive
Work in progress.
7 years, 5 months ago (2013-06-29 07:00:12 UTC) #1
abarth-chromium
Would you be willing to send an "intent to ship" email for this change? http://dev.chromium.org/blink#launch-process
7 years, 5 months ago (2013-06-29 18:01:20 UTC) #2
gyuyoung-inactive
On 2013/06/29 18:01:20, abarth wrote: > Would you be willing to send an "intent to ...
7 years, 5 months ago (2013-06-30 02:47:38 UTC) #3
gyuyoung-inactive
On 2013/06/30 02:47:38, gyuyoung wrote: > On 2013/06/29 18:01:20, abarth wrote: > > Would you ...
7 years, 5 months ago (2013-07-06 05:42:56 UTC) #4
gyuyoung-inactive
To support the custom scheme handler feature, I upload a patch in order to add ...
6 years, 11 months ago (2014-01-10 04:01:27 UTC) #5
gyuyoung-inactive
On 2014/01/10 04:01:27, gyuyoung wrote: > To support the custom scheme handler feature, I upload ...
6 years, 11 months ago (2014-01-16 03:50:12 UTC) #6
abarth-chromium
lgtm https://codereview.chromium.org/18179009/diff/48001/public/web/WebViewClient.h File public/web/WebViewClient.h (right): https://codereview.chromium.org/18179009/diff/48001/public/web/WebViewClient.h#newcode362 public/web/WebViewClient.h:362: virtual void unregisterProtocolHandler(const WebString& scheme, const WebString& baseUrl, ...
6 years, 11 months ago (2014-01-16 04:46:44 UTC) #7
gyuyoung-inactive
https://codereview.chromium.org/18179009/diff/48001/public/web/WebViewClient.h File public/web/WebViewClient.h (right): https://codereview.chromium.org/18179009/diff/48001/public/web/WebViewClient.h#newcode362 public/web/WebViewClient.h:362: virtual void unregisterProtocolHandler(const WebString& scheme, const WebString& baseUrl, const ...
6 years, 11 months ago (2014-01-16 05:12:10 UTC) #8
gyuyoung-inactive
https://codereview.chromium.org/18179009/diff/48001/public/web/WebViewClient.h File public/web/WebViewClient.h (right): https://codereview.chromium.org/18179009/diff/48001/public/web/WebViewClient.h#newcode362 public/web/WebViewClient.h:362: virtual void unregisterProtocolHandler(const WebString& scheme, const WebString& baseUrl, const ...
6 years, 11 months ago (2014-01-16 05:17:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18179009/48001
6 years, 11 months ago (2014-01-16 05:52:10 UTC) #10
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) wtf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7674
6 years, 11 months ago (2014-01-16 06:37:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18179009/228001
6 years, 11 months ago (2014-01-16 07:41:07 UTC) #12
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) wtf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7710
6 years, 11 months ago (2014-01-16 08:32:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/18179009/228001
6 years, 11 months ago (2014-01-17 05:41:47 UTC) #14
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 05:56:57 UTC) #15
Message was sent while issue was closed.
Change committed as 165276

Powered by Google App Engine
This is Rietveld 408576698