chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc - Issue 18179004: Dismiss action in tab modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

Issue 18179004: Dismiss action in tab modal dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make the tests pass with GTK and Cocoa Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

index 77819fe8ac7ec90b7c265f99daa4581ca56948e6..22465c51a0f5c71c049f226fa05556edce7d5e8d 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_editor_view.cc

@@ -229,11 +229,6 @@ void BookmarkEditorView::Show(gfx::NativeWindow parent) {

title_tf_->RequestFocus();

}

-void BookmarkEditorView::Close() {

- DCHECK(GetWidget());

- GetWidget()->Close();

void BookmarkEditorView::ShowContextMenuForView(

views::View* source,

const gfx::Point& point,