chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm - Issue 18179004: Dismiss action in tab modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm

Issue 18179004: Dismiss action in tab modal dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make the tests pass with GTK and Cocoa Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm

diff --git a/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm b/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm

index 6966adcd7df5e1f919b0e9699ffa46af02bbbffc..9c1c67a2298de6da2b421f633f0ea6cd30bb7454 100644

--- a/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm

+++ b/chrome/browser/ui/cocoa/tab_modal_confirm_dialog_mac.mm

@@ -114,6 +114,6 @@ void TabModalConfirmDialogMac::OnConstrainedWindowClosed(

ConstrainedWindowMac* window) {

// Provide a disposition in case the dialog was closed without accepting or

// cancelling.

- delegate_->Cancel();

+ delegate_->Close();

fdoray 2013/07/24 20:21:07 Cannot be done in a separate CL because the tests

delete this;

}