chrome/browser/ui/views/javascript_app_modal_dialog_views.cc - Issue 18179004: Dismiss action in tab modal dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

Issue 18179004: Dismiss action in tab modal dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, fix CrOS build Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

diff --git a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

index ed4c6a204d62284258b16d91c5dad565d303139f..ef485a163d9f288afda37d9b944972de3b4bd953 100644

--- a/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

+++ b/chrome/browser/ui/views/javascript_app_modal_dialog_views.cc

@@ -108,7 +108,7 @@ bool JavaScriptAppModalDialogViews::Accept() {

return true;

}

-void JavaScriptAppModalDialogViews::OnClose() {

+void JavaScriptAppModalDialogViews::OnClosed() {

parent_->OnClose();

}