Print with the correct physical dimensions when specified

Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
Committed: https://crrev.com/a7fd168b96a0f6896b4a4e3d88921998e56f49c0
Cr-Commit-Position: refs/heads/master@{#384518}

[rhogan, 2016-03-20 16:17:26]

Description was changed from

==========
bug 273306

BUG=273306
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

[rhogan, 2016-03-20 16:17:26]

robhogan@gmail.com changed reviewers:
+ thestig@chromium.org

[rhogan, 2016-03-21 18:38:07]

Description was changed from

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945 
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

[rhogan, 2016-03-21 18:43:30]

thestig - would you mind taking a look? I can provide updated results in a
second CL but wanted to be sure you think I'm on the right track here.

[rhogan, 2016-03-23 20:39:59]

robhogan@gmail.com changed reviewers:
+ eae@chromium.org

[rhogan, 2016-03-23 20:40:24]

On 2016/03/21 at 18:43:30, rhogan wrote:
> thestig - would you mind taking a look? I can provide updated results in a
second CL but wanted to be sure you think I'm on the right track here.

eae - in thestig's absence, who would be a good person to take a look at this?

[eae, 2016-03-23 21:16:56]

Sure!

https://codereview.chromium.org/1817873002/diff/1/components/printing/rendere...
File components/printing/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/1817873002/diff/1/components/printing/rendere...
components/printing/renderer/print_web_view_helper.cc:679: // Layout page
according to printer page size. Since WebKit shrinks the
This comment needs updating. Would also be great if you could include some of
the details from the bug and change list description here.

https://codereview.chromium.org/1817873002/diff/1/components/printing/rendere...
components/printing/renderer/print_web_view_helper.cc:688:
static_cast<int>(static_cast<double>(print_layout_size.height()) * 1.33));
How about making this a constant and using it both here and below? (and ideally
in blink, that might be hard though).

[rhogan, 2016-03-24 19:16:49]

On 2016/03/23 at 21:16:56, eae wrote:
> Sure!
> 
>
https://codereview.chromium.org/1817873002/diff/1/components/printing/rendere...
> File components/printing/renderer/print_web_view_helper.cc (right):
> 
>
https://codereview.chromium.org/1817873002/diff/1/components/printing/rendere...
> components/printing/renderer/print_web_view_helper.cc:679: // Layout page
according to printer page size. Since WebKit shrinks the
> This comment needs updating. Would also be great if you could include some of
the details from the bug and change list description here.
> 
>
https://codereview.chromium.org/1817873002/diff/1/components/printing/rendere...
> components/printing/renderer/print_web_view_helper.cc:688:
static_cast<int>(static_cast<double>(print_layout_size.height()) * 1.33));
> How about making this a constant and using it both here and below? (and
ideally in blink, that might be hard though).

OK to take another look?

[eae, 2016-03-24 19:26:36]

Thank you, LGTM

[eae, 2016-03-24 19:26:42]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2016-03-24 19:27:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/60001

[commit-bot: I haz the power, 2016-03-24 19:39:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 19:39:31]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rhogan, 2016-03-24 19:42:06]

robhogan@gmail.com changed reviewers:
+ alekseys@chromium.org, gene@chromium.org

[rhogan, 2016-03-24 19:42:47]

On 2016/03/24 at 19:39:31, commit-bot wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

alekseys/gene/thestig - the CQ needs an LGTM from one of you guys too. Can you
take a look?

[Lei Zhang, 2016-03-29 01:00:46]

Just have a couple small nits;

https://codereview.chromium.org/1817873002/diff/140001/components/printing/re...
File components/printing/renderer/print_web_view_helper.cc (right):

https://codereview.chromium.org/1817873002/diff/140001/components/printing/re...
components/printing/renderer/print_web_view_helper.cc:80: const float
kPrintingMinimumShrinkFactor = 1.333f;
Can you reference third_party/WebKit/Source/core/page/PrintContext.cpp which has
the same constant?

https://codereview.chromium.org/1817873002/diff/140001/components/printing/re...
components/printing/renderer/print_web_view_helper.cc:685: // was 'about right'.
However per crbug.com/273306 1.333 seems to be
https://crbug.com/...

[rhogan, 2016-03-29 18:34:27]

On 2016/03/29 at 01:00:46, thestig wrote:
> Just have a couple small nits;

Both addressed - thanks thestig. You OK to look-good-to-me it?

[Lei Zhang, 2016-03-29 18:49:56]

lgtm

[rhogan, 2016-03-29 19:17:23]

https://codereview.chromium.org/1817873002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/page/PrintContext.cpp (right):

https://codereview.chromium.org/1817873002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/page/PrintContext.cpp:105: int pageHeight =
pageSizeInPixels.height() + LayoutUnit::epsilon();
eae: I added this change since you lgtm'd it. Can you TAL?

[eae, 2016-03-29 19:28:47]

still LGTM

https://codereview.chromium.org/1817873002/diff/160001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/page/PrintContext.cpp (right):

https://codereview.chromium.org/1817873002/diff/160001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/page/PrintContext.cpp:105: int pageHeight =
pageSizeInPixels.height() + LayoutUnit::epsilon();
On 2016/03/29 19:17:23, rhogan wrote:
> eae: I added this change since you lgtm'd it. Can you TAL?

I'd prefer if we snapped it rather than added epsilon but I trust your
judgement.

[rhogan, 2016-03-29 20:26:14]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-03-29 20:26:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1817873002/#ps180001
(title: "Updated")

[commit-bot: I haz the power, 2016-03-29 20:27:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/180001

[commit-bot: I haz the power, 2016-03-29 20:38:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 20:38:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rhogan, 2016-03-29 21:17:36]

robhogan@gmail.com changed reviewers:
+ pdr@chromium.org

[rhogan, 2016-03-29 21:17:37]

pdr: could you lgtm the change to WebFrame.h? It's just a comment change but the
presubmit bot needs an OWNER from public/.

[pdr., 2016-03-29 23:05:44]

On 2016/03/29 at 21:17:37, robhogan wrote:
> pdr: could you lgtm the change to WebFrame.h? It's just a comment change but
the presubmit bot needs an OWNER from public/.

LGTM

It's always a judgement call for these things, but for comment changes reviewed
by eae, I'd be okay if you TBR=pdr.

[rhogan, 2016-03-30 05:06:46]

Oh right, forgot about TBR! Thanks anyway.

On Wed, 30 Mar 2016 00:05 , <pdr@chromium.org> wrote:

> On 2016/03/29 at 21:17:37, robhogan wrote:
> > pdr: could you lgtm the change to WebFrame.h? It's just a comment change
> but
> the presubmit bot needs an OWNER from public/.
>
> LGTM
>
> It's always a judgement call for these things, but for comment changes
> reviewed
> by eae, I'd be okay if you TBR=pdr.
>
> https://codereview.chromium.org/1817873002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 05:06:46]

Oh right, forgot about TBR! Thanks anyway.

On Wed, 30 Mar 2016 00:05 , <pdr@chromium.org> wrote:

> On 2016/03/29 at 21:17:37, robhogan wrote:
> > pdr: could you lgtm the change to WebFrame.h? It's just a comment change
> but
> the presubmit bot needs an OWNER from public/.
>
> LGTM
>
> It's always a judgement call for these things, but for comment changes
> reviewed
> by eae, I'd be okay if you TBR=pdr.
>
> https://codereview.chromium.org/1817873002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 06:52:07]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-03-30 06:52:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/180001

[commit-bot: I haz the power, 2016-03-30 07:48:33]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-03-30 07:49:38]

Description was changed from

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945 
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306

Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
Cr-Commit-Position: refs/heads/master@{#383925}
==========

[commit-bot: I haz the power, 2016-03-30 07:49:39]

Patchset 10 (id:??) landed as
https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
Cr-Commit-Position: refs/heads/master@{#383925}

[Nico, 2016-03-30 12:11:55]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-03-30 12:11:56]

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 has been
red since this landed.

[rhogan, 2016-03-30 12:47:55]

Maybe my rebaselines for Win10 weren't quite right? You OK to rebaselines
and the me?

On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:

> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 has
> been
> red since this landed.
>
> https://codereview.chromium.org/1817873002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 12:47:55]

Maybe my rebaselines for Win10 weren't quite right? You OK to rebaselines
and the me?

On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:

> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 has
> been
> red since this landed.
>
> https://codereview.chromium.org/1817873002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 12:58:51]

On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com> wrote:

> Maybe my rebaselines for Win10 weren't quite right? You OK to rebaselines
> and the me?


What?


>
>
> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>
>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 has
>> been
>> red since this landed.
>>
>> https://codereview.chromium.org/1817873002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 12:58:52]

On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com> wrote:

> Maybe my rebaselines for Win10 weren't quite right? You OK to rebaselines
> and the me?


What?


>
>
> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>
>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10 has
>> been
>> red since this landed.
>>
>> https://codereview.chromium.org/1817873002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 15:24:38]

Sorry I thought you were sheriffing. Jochen has looked after it.

On Wed, 30 Mar 2016 13:58 Nico Weber, <thakis@chromium.org> wrote:

> On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com> wrote:
>
>> Maybe my rebaselines for Win10 weren't quite right? You OK to rebaselines
>> and the me?
>
>
> What?
>
>
>>
>>
>> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>>
>>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
>>> has been
>>> red since this landed.
>>>
>>> https://codereview.chromium.org/1817873002/
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 15:24:39]

Sorry I thought you were sheriffing. Jochen has looked after it.

On Wed, 30 Mar 2016 13:58 Nico Weber, <thakis@chromium.org> wrote:

> On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com> wrote:
>
>> Maybe my rebaselines for Win10 weren't quite right? You OK to rebaselines
>> and the me?
>
>
> What?
>
>
>>
>>
>> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>>
>>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
>>> has been
>>> red since this landed.
>>>
>>> https://codereview.chromium.org/1817873002/
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 15:33:17]

I mean I didn't understand what "and the me" meant
On Mar 30, 2016 11:24 AM, "Robert Hogan" <robhogan@gmail.com> wrote:

> Sorry I thought you were sheriffing. Jochen has looked after it.
>
> On Wed, 30 Mar 2016 13:58 Nico Weber, <thakis@chromium.org> wrote:
>
>> On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com> wrote:
>>
>>> Maybe my rebaselines for Win10 weren't quite right? You OK to
>>> rebaselines and the me?
>>
>>
>> What?
>>
>>
>>>
>>>
>>> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>>>
>>>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
>>>> has been
>>>> red since this landed.
>>>>
>>>> https://codereview.chromium.org/1817873002/
>>>>
>>>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[Nico, 2016-03-30 15:33:17]

I mean I didn't understand what "and the me" meant
On Mar 30, 2016 11:24 AM, "Robert Hogan" <robhogan@gmail.com> wrote:

> Sorry I thought you were sheriffing. Jochen has looked after it.
>
> On Wed, 30 Mar 2016 13:58 Nico Weber, <thakis@chromium.org> wrote:
>
>> On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com> wrote:
>>
>>> Maybe my rebaselines for Win10 weren't quite right? You OK to
>>> rebaselines and the me?
>>
>>
>> What?
>>
>>
>>>
>>>
>>> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>>>
>>>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
>>>> has been
>>>> red since this landed.
>>>>
>>>> https://codereview.chromium.org/1817873002/
>>>>
>>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 16:03:33]

Oh typo: I meant TBR.

On Wed, 30 Mar 2016 16:33 Nico Weber, <thakis@chromium.org> wrote:

> I mean I didn't understand what "and the me" meant
> On Mar 30, 2016 11:24 AM, "Robert Hogan" <robhogan@gmail.com> wrote:
>
>> Sorry I thought you were sheriffing. Jochen has looked after it.
>>
>> On Wed, 30 Mar 2016 13:58 Nico Weber, <thakis@chromium.org> wrote:
>>
>>> On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com>
>>> wrote:
>>>
>>>> Maybe my rebaselines for Win10 weren't quite right? You OK to
>>>> rebaselines and the me?
>>>
>>>
>>> What?
>>>
>>>
>>>>
>>>>
>>>> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>>>>
>>>>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
>>>>> has been
>>>>> red since this landed.
>>>>>
>>>>> https://codereview.chromium.org/1817873002/
>>>>>
>>>>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-30 16:03:33]

Oh typo: I meant TBR.

On Wed, 30 Mar 2016 16:33 Nico Weber, <thakis@chromium.org> wrote:

> I mean I didn't understand what "and the me" meant
> On Mar 30, 2016 11:24 AM, "Robert Hogan" <robhogan@gmail.com> wrote:
>
>> Sorry I thought you were sheriffing. Jochen has looked after it.
>>
>> On Wed, 30 Mar 2016 13:58 Nico Weber, <thakis@chromium.org> wrote:
>>
>>> On Wed, Mar 30, 2016 at 8:47 AM, Robert Hogan <robhogan@gmail.com>
>>> wrote:
>>>
>>>> Maybe my rebaselines for Win10 weren't quite right? You OK to
>>>> rebaselines and the me?
>>>
>>>
>>> What?
>>>
>>>
>>>>
>>>>
>>>> On Wed, 30 Mar 2016 13:11 , <thakis@chromium.org> wrote:
>>>>
>>>>> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10
>>>>> has been
>>>>> red since this landed.
>>>>>
>>>>> https://codereview.chromium.org/1817873002/
>>>>>
>>>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Devlin, 2016-03-30 22:40:14]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1848443003/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Causing failures on Webkit Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190

unexpected_failures:
printing/quirks-percentage-height-body.html
virtual/threaded/printing/standards-percentage-heights.html
virtual/threaded/printing/subframes-percentage-height.html
virtual/threaded/printing/quirks-percentage-height.html
printing/standards-percentage-heights.html
printing/quirks-percentage-height.html
virtual/threaded/printing/quirks-percentage-height-body.html
printing/subframes-percentage-height.html
.

[rhogan, 2016-03-31 18:08:17]

Description was changed from

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306

Committed: https://crrev.com/b0b70b1a7023b375e31b94799e109fd1c19005c0
Cr-Commit-Position: refs/heads/master@{#383925}
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

[rhogan, 2016-03-31 18:10:03]

On 2016/03/30 at 22:40:14, rdevlin.cronin wrote:
> A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1848443003/ by rdevlin.cronin@chromium.org.
> 
> The reason for reverting is: Causing failures on Webkit Win10:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
> 
> unexpected_failures:
> printing/quirks-percentage-height-body.html
> virtual/threaded/printing/standards-percentage-heights.html
> virtual/threaded/printing/subframes-percentage-height.html
> virtual/threaded/printing/quirks-percentage-height.html
> printing/standards-percentage-heights.html
> printing/quirks-percentage-height.html
> virtual/threaded/printing/quirks-percentage-height-body.html
> printing/subframes-percentage-height.html
> .

I'm relanding with updated TestExpectations. The Win10 compaining that the above
tests have no expected results doesn't make much sense given that they're not
new tests. I'm must going to auto-rebaseline these tests on both Win7 and Win10.

[rhogan, 2016-03-31 18:10:18]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-03-31 18:10:19]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
thestig@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1817873002/#ps200001
(title: "Updated")

[commit-bot: I haz the power, 2016-03-31 18:10:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/200001

[commit-bot: I haz the power, 2016-03-31 18:24:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 18:24:24]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[rhogan, 2016-03-31 20:56:12]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-03-31 20:56:14]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
thestig@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1817873002/#ps220001
(title: "Updated")

[commit-bot: I haz the power, 2016-03-31 20:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/220001

[Devlin, 2016-03-31 21:31:07]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-31 21:33:16]

On 2016/03/31 18:10:03, rhogan wrote:
> On 2016/03/30 at 22:40:14, rdevlin.cronin wrote:
> > A revert of this CL (patchset #10 id:180001) has been created in
> https://codereview.chromium.org/1848443003/ by
mailto:rdevlin.cronin@chromium.org.
> > 
> > The reason for reverting is: Causing failures on Webkit Win10:
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
> > 
> > unexpected_failures:
> > printing/quirks-percentage-height-body.html
> > virtual/threaded/printing/standards-percentage-heights.html
> > virtual/threaded/printing/subframes-percentage-height.html
> > virtual/threaded/printing/quirks-percentage-height.html
> > printing/standards-percentage-heights.html
> > printing/quirks-percentage-height.html
> > virtual/threaded/printing/quirks-percentage-height-body.html
> > printing/subframes-percentage-height.html
> > .
> 
> I'm relanding with updated TestExpectations. The Win10 compaining that the
above
> tests have no expected results doesn't make much sense given that they're not
> new tests. I'm must going to auto-rebaseline these tests on both Win7 and
Win10.

As mentioned in IRC, the reason these failed on win10 was that the bot couldn't
find the expected results, so I don't think marking them as failing tests would
help (in fact, many are already marked as failing) since the bots treat missing
expectation files as a separate error.  I'm not familiar enough with blink
layout tests to know if marking them as rebaseline would be sufficient - would
it?

(temporarily unchecking commit box until this is sorted out)

[Devlin, 2016-03-31 21:33:33]

Description was changed from

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

[rhogan, 2016-03-31 21:44:05]

Yes, it should be fine. I've removed the Win10 specific failure
expectations for a group of tests that I'm converting from ref tests to PNG
tests. I believe this is why Win10 was giving trouble - it was looking for
failures that no longer happened.

On Thu, 31 Mar 2016 22:33 , <rdevlin.cronin@chromium.org> wrote:

> On 2016/03/31 18:10:03, rhogan wrote:
> > On 2016/03/30 at 22:40:14, rdevlin.cronin wrote:
> > > A revert of this CL (patchset #10 id:180001) has been created in
> > https://codereview.chromium.org/1848443003/ by
> mailto:rdevlin.cronin@chromium.org.
>
> > >
> > > The reason for reverting is: Causing failures on Webkit Win10:
> >
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
> > >
> > > unexpected_failures:
> > > printing/quirks-percentage-height-body.html
> > > virtual/threaded/printing/standards-percentage-heights.html
> > > virtual/threaded/printing/subframes-percentage-height.html
> > > virtual/threaded/printing/quirks-percentage-height.html
> > > printing/standards-percentage-heights.html
> > > printing/quirks-percentage-height.html
> > > virtual/threaded/printing/quirks-percentage-height-body.html
> > > printing/subframes-percentage-height.html
> > > .
> >
> > I'm relanding with updated TestExpectations. The Win10 compaining that
> the
> above
> > tests have no expected results doesn't make much sense given that
> they're not
> > new tests. I'm must going to auto-rebaseline these tests on both Win7 and
> Win10.
>
> As mentioned in IRC, the reason these failed on win10 was that the bot
> couldn't
> find the expected results, so I don't think marking them as failing tests
> would
> help (in fact, many are already marked as failing) since the bots treat
> missing
> expectation files as a separate error. I'm not familiar enough with blink
> layout tests to know if marking them as rebaseline would be sufficient -
> would
> it?
>
> (temporarily unchecking commit box until this is sorted out)
>
> https://codereview.chromium.org/1817873002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-31 21:44:05]

Yes, it should be fine. I've removed the Win10 specific failure
expectations for a group of tests that I'm converting from ref tests to PNG
tests. I believe this is why Win10 was giving trouble - it was looking for
failures that no longer happened.

On Thu, 31 Mar 2016 22:33 , <rdevlin.cronin@chromium.org> wrote:

> On 2016/03/31 18:10:03, rhogan wrote:
> > On 2016/03/30 at 22:40:14, rdevlin.cronin wrote:
> > > A revert of this CL (patchset #10 id:180001) has been created in
> > https://codereview.chromium.org/1848443003/ by
> mailto:rdevlin.cronin@chromium.org.
>
> > >
> > > The reason for reverting is: Causing failures on Webkit Win10:
> >
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/8190
> > >
> > > unexpected_failures:
> > > printing/quirks-percentage-height-body.html
> > > virtual/threaded/printing/standards-percentage-heights.html
> > > virtual/threaded/printing/subframes-percentage-height.html
> > > virtual/threaded/printing/quirks-percentage-height.html
> > > printing/standards-percentage-heights.html
> > > printing/quirks-percentage-height.html
> > > virtual/threaded/printing/quirks-percentage-height-body.html
> > > printing/subframes-percentage-height.html
> > > .
> >
> > I'm relanding with updated TestExpectations. The Win10 compaining that
> the
> above
> > tests have no expected results doesn't make much sense given that
> they're not
> > new tests. I'm must going to auto-rebaseline these tests on both Win7 and
> Win10.
>
> As mentioned in IRC, the reason these failed on win10 was that the bot
> couldn't
> find the expected results, so I don't think marking them as failing tests
> would
> help (in fact, many are already marked as failing) since the bots treat
> missing
> expectation files as a separate error. I'm not familiar enough with blink
> layout tests to know if marking them as rebaseline would be sufficient -
> would
> it?
>
> (temporarily unchecking commit box until this is sorted out)
>
> https://codereview.chromium.org/1817873002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rhogan, 2016-03-31 21:44:56]

The CQ bit was checked by robhogan@gmail.com

[commit-bot: I haz the power, 2016-03-31 21:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/220001

[commit-bot: I haz the power, 2016-03-31 22:33:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 22:33:38]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[rhogan, 2016-04-01 06:44:54]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-04-01 06:44:55]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
thestig@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1817873002/#ps240001
(title: "Updated")

[commit-bot: I haz the power, 2016-04-01 06:45:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817873002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817873002/240001

[commit-bot: I haz the power, 2016-04-01 08:29:46]

Description was changed from

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

[commit-bot: I haz the power, 2016-04-01 08:29:48]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-04-01 08:31:26]

Description was changed from

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306
==========

to

==========
Print with the correct physical dimensions when specified

If you specify a div in cm, mm or a similar unit of physical measurement and
print it you don't get an element of the expected size on paper. This is due
to the scaling factor we use when resizing the page for printing.

The scaling factor of 1.25 was introduced by
https://trac.webkit.org/changeset/22945
and adopted in the Gtk port by http://wkbug.com/15576. It seems to
be a magic number that was 'about right'. From trial and error 1.33 seems to be
the magic number that produces output with the correct physical size.

I don't know how to test this.

BUG=273306

Committed: https://crrev.com/a7fd168b96a0f6896b4a4e3d88921998e56f49c0
Cr-Commit-Position: refs/heads/master@{#384518}
==========

[commit-bot: I haz the power, 2016-04-01 08:31:27]

Patchset 13 (id:??) landed as
https://crrev.com/a7fd168b96a0f6896b4a4e3d88921998e56f49c0
Cr-Commit-Position: refs/heads/master@{#384518}