Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 181783009: Add use counter for insertAdjacentHTML (Closed)

Created:
6 years, 9 months ago by spartha
Modified:
6 years, 9 months ago
Reviewers:
tkent, ojan, eseidel
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add use counter for insertAdjacentHTML Adding measure for insertAdjacentHTML. The other two related interfaces InsertAdjacentText and InsertAdjacentElement are already measured. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168117

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
spartha
6 years, 9 months ago (2014-02-27 03:53:09 UTC) #1
ojan
lgtm
6 years, 9 months ago (2014-02-27 20:22:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/181783009/1
6 years, 9 months ago (2014-02-27 20:22:10 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 23:44:38 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=29495
6 years, 9 months ago (2014-02-27 23:44:39 UTC) #5
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 9 months ago (2014-02-28 04:06:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/181783009/1
6 years, 9 months ago (2014-02-28 04:06:55 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 04:06:57 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-02-28 04:06:57 UTC) #9
tkent
lgtm
6 years, 9 months ago (2014-02-28 06:14:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/181783009/20001
6 years, 9 months ago (2014-02-28 06:14:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-28 08:29:50 UTC) #12
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-02-28 08:29:50 UTC) #13
spartha
The CQ bit was checked by sudarshan.p@samsung.com
6 years, 9 months ago (2014-02-28 09:32:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sudarshan.p@samsung.com/181783009/40001
6 years, 9 months ago (2014-02-28 09:34:07 UTC) #15
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 11:14:51 UTC) #16
Message was sent while issue was closed.
Change committed as 168117

Powered by Google App Engine
This is Rietveld 408576698