Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
181783002:
Add a UseCounter for SVGElement.className. (Closed)
|
Created:
6 years, 10 months ago by Erik Dahlström (inactive) Modified:
6 years, 9 months ago CC:
blink-reviews, krit, arv+blink, fs, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, f(malita), Inactive, gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionAdd a UseCounter for SVGElement.className.
BUG=
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168147
Patch Set 1 #Patch Set 2 : rebased #Patch Set 3 : rebased #
Messages
Total messages: 25 (0 generated)
To get data for possibly aligning with html className instead.
lgtm lgtm Not sure if it needs an lgtm from an API owner though.
The CQ bit was checked by ed@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/181783002/1
The CQ bit was unchecked by schenney@chromium.org
not lgtm. You need to update src/tools/metrics/histograms/histograms.xml at line 26668
On 2014/02/27 17:37:04, Stephen Chenney wrote: > not lgtm. > > You need to update src/tools/metrics/histograms/histograms.xml at line 26668 That has to be done as a separate patch
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/181783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
On 2014/02/27 22:08:27, I haz the power (commit-bot) wrote: > Retried try job too often on linux_blink for step(s) webkit_tests > http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin... Stupid flakes :< Clicking commit again.
The CQ bit was checked by pdr@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/181783002/1
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/181783002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...
The CQ bit was checked by ed@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/181783002/20001
The CQ bit was checked by ed@opera.com
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for Source/core/frame/UseCounter.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
patching file Source/core/frame/UseCounter.h
Hunk #1 FAILED at 297.
1 out of 1 hunk FAILED -- saving rejects to file
Source/core/frame/UseCounter.h.rej
Patch: Source/core/frame/UseCounter.h
Index: Source/core/frame/UseCounter.h
diff --git a/Source/core/frame/UseCounter.h b/Source/core/frame/UseCounter.h
index
594d928e2bca5ea5fc2b753dee7ed8d45cfbbb15..02af167441b67c33f48e5161eb9e4f0eced0bbfc
100644
--- a/Source/core/frame/UseCounter.h
+++ b/Source/core/frame/UseCounter.h
@@ -297,6 +297,7 @@ public:
TextAutosizingLayout = 275,
HTMLAnchorElementPingAttribute = 276,
JavascriptExhaustedMemory = 277,
+ SVGClassName = 278,
// Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots.
NumberOfFeatures, // This enum value must be last.
The CQ bit was checked by ed@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/181783002/40001
Message was sent while issue was closed.
Change committed as 168147 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
