Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1817793002:
Fix uninitialized fCurrProgramID in GrGLCreateNullInterface (Closed)
DescriptionFix uninitialized fCurrProgramID in GrGLCreateNullInterface
TBR=bsalomon@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1817793002
Committed: https://skia.googlesource.com/skia/+/ba73ad0f3a6d9d505cae08e4f3cc5d2d6b9b1501
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
Description was changed from ========== Fix uninitialized fCurrProgramID in GrGLCreateNullInterface TBR=bsalomon@google.com,robertphillips@google.com ========== to ========== Fix uninitialized fCurrProgramID in GrGLCreateNullInterface TBR=bsalomon@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Speculative fix for Chromium MSAN failures: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test... [ RUN ] GpuRasterizationRasterizesBorderTiles.RunMultiThread_DelegatingRenderer ==15910==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x44e0d2c in finalize third_party/skia/src/gpu/gl/builders/GrGLProgramBuilder.cpp:101:9 #1 0x44df680 in CreateProgram third_party/skia/src/gpu/gl/builders/GrGLProgramBuilder.cpp:52:12 #2 0x44743fc in refProgram third_party/skia/src/gpu/gl/GrGLGpuProgramCache.cpp:155:32 #3 0x444094b in flushGLState third_party/skia/src/gpu/gl/GrGLGpu.cpp:2081:39 #4 0x445a431 in onDraw third_party/skia/src/gpu/gl/GrGLGpu.cpp:2916:10 #5 0x438e928 in onDraw third_party/skia/src/gpu/batches/GrVertexBatch.cpp:76:9 #6 0x426e044 in draw third_party/skia/src/gpu/batches/GrBatch.h:112:43 #7 0x426e044 in drawBatches third_party/skia/src/gpu/GrDrawTarget.cpp:226:0 #8 0x4268824 in flush third_party/skia/src/gpu/GrDrawingManager.cpp:84:9 #9 0x424f2f3 in flush third_party/skia/src/gpu/GrContext.cpp:218:9 #10 0x424f2f3 in prepareSurfaceForExternalIO third_party/skia/src/gpu/GrContext.cpp:514:0 #11 0x3346ede in ReleaseSkSurface cc/resources/resource_provider.cc:1148:3 #12 0x3601f4f in RasterizeSource cc/raster/gpu_rasterizer.cc:84:5 #13 0x32e44d2 in Playback cc/raster/gpu_tile_task_worker_pool.cc:65:5 #14 0x340f5ac in RunOnWorkerThread cc/tiles/tile_manager.cc:94:5 #15 0x33011cc in RunTaskWithLockAcquired cc/raster/single_thread_task_graph_runner.cc:156:5 #16 0x3301748 in Run cc/raster/single_thread_task_graph_runner.cc:117:10 #17 0x3301748 in ?? cc/raster/single_thread_task_graph_runner.cc:113:0 #18 0x394b8a5 in ?? base/threading/simple_thread.cc:87:3 #19 0x394b566 in ThreadMain base/threading/simple_thread.cc:66:3 #20 0x394148f in ThreadFunc base/threading/platform_thread_posix.cc:68:3 #21 0x7fe2cb082e99 in start_thread /build/eglibc-rrybNj/eglibc-2.15/nptl/pthread_create.c:308:0 #22 0x7fe2cab9a38c in ?? /build/eglibc-rrybNj/eglibc-2.15/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:112:0 Uninitialized value was stored to memory at #0 0x490e2e3 in ?? third_party/skia/src/gpu/gl/GrGLCreateNullInterface.cpp:163:16 #1 0x441f77b in operator() buildtools/third_party/libc++/trunk/include/functional:1891:12 #2 0x441f77b in createCopyPrograms third_party/skia/src/gpu/gl/GrGLGpu.cpp:3804:0 #3 0x441daea in GrGLGpu third_party/skia/src/gpu/gl/GrGLGpu.cpp:227:5 #4 0x441ce82 in Create third_party/skia/src/gpu/gl/GrGLGpu.cpp:181:20 #5 0x428e3f4 in ?? third_party/skia/src/gpu/GrGpuFactory.cpp:36:12 #6 0x4245886 in init third_party/skia/src/gpu/GrContext.cpp:74:12 #7 0x4245886 in Create third_party/skia/src/gpu/GrContext.cpp:43:0 #8 0x42453d3 in Create third_party/skia/src/gpu/GrContext.cpp:36:12 #9 0x384650c in GrContext cc/test/test_context_provider.cc:117:32 #10 0x34c0a0f in CanUseGpuRasterization cc/trees/layer_tree_host_impl.cc:1722:8 #11 0x34c0a0f in UpdateGpuRasterizationStatus cc/trees/layer_tree_host_impl.cc:1757:0 #12 0x34cb1c6 in InitializeRenderer cc/trees/layer_tree_host_impl.cc:2314:3 #13 0x38115ca in ?? cc/test/layer_tree_test.cc:292:20 #14 0x360e149 in InitializeOutputSurfaceOnImpl cc/trees/proxy_impl.cc:137:18 #15 0x35a5302 in Run\u003Ccc::OutputSurface *const &> base/bind_internal.h:181:12 #16 0x35a5302 in MakeItSo\u003Cbase::WeakPtr\u003Ccc::ProxyImpl>, cc::OutputSurface *const &> base/bind_internal.h:314:0 #17 0x35a5302 in Run base/bind_internal.h:352:0 #18 0x39dc6b4 in Run base/callback.h:397:12 #19 0x39dc6b4 in RunTask base/debug/task_annotator.cc:51:0 #20 0x38bef4f in RunTask base/message_loop/message_loop.cc:476:3 #21 0x38c0777 in DeferOrRunPendingTask base/message_loop/message_loop.cc:485:5 #22 0x38c1265 in DoWork base/message_loop/message_loop.cc:597:13 #23 0x38cd333 in Run base/message_loop/message_pump_default.cc:33:21 #24 0x3901754 in Run base/run_loop.cc:35:3 #25 0x38bd3b4 in ?? base/message_loop/message_loop.cc:293:3 Uninitialized value was stored to memory at #0 0x490e2e3 in ?? third_party/skia/src/gpu/gl/GrGLCreateNullInterface.cpp:163:16 #1 0x441f77b in operator() buildtools/third_party/libc++/trunk/include/functional:1891:12 #2 0x441f77b in createCopyPrograms third_party/skia/src/gpu/gl/GrGLGpu.cpp:3804:0 #3 0x441daea in GrGLGpu third_party/skia/src/gpu/gl/GrGLGpu.cpp:227:5 #4 0x441ce82 in Create third_party/skia/src/gpu/gl/GrGLGpu.cpp:181:20 #5 0x428e3f4 in ?? third_party/skia/src/gpu/GrGpuFactory.cpp:36:12 #6 0x4245886 in init third_party/skia/src/gpu/GrContext.cpp:74:12 #7 0x4245886 in Create third_party/skia/src/gpu/GrContext.cpp:43:0 #8 0x42453d3 in Create third_party/skia/src/gpu/GrContext.cpp:36:12 #9 0x384650c in GrContext cc/test/test_context_provider.cc:117:32 #10 0x34c0a0f in CanUseGpuRasterization cc/trees/layer_tree_host_impl.cc:1722:8 #11 0x34c0a0f in UpdateGpuRasterizationStatus cc/trees/layer_tree_host_impl.cc:1757:0 #12 0x34cb1c6 in InitializeRenderer cc/trees/layer_tree_host_impl.cc:2314:3 #13 0x38115ca in ?? cc/test/layer_tree_test.cc:292:20 #14 0x360e149 in InitializeOutputSurfaceOnImpl cc/trees/proxy_impl.cc:137:18 #15 0x35a5302 in Run\u003Ccc::OutputSurface *const &> base/bind_internal.h:181:12 #16 0x35a5302 in MakeItSo\u003Cbase::WeakPtr\u003Ccc::ProxyImpl>, cc::OutputSurface *const &> base/bind_internal.h:314:0 #17 0x35a5302 in Run base/bind_internal.h:352:0 #18 0x39dc6b4 in Run base/callback.h:397:12 #19 0x39dc6b4 in RunTask base/debug/task_annotator.cc:51:0 #20 0x38bef4f in RunTask base/message_loop/message_loop.cc:476:3 #21 0x38c0777 in DeferOrRunPendingTask base/message_loop/message_loop.cc:485:5 #22 0x38c1265 in DoWork base/message_loop/message_loop.cc:597:13 #23 0x38cd333 in Run base/message_loop/message_pump_default.cc:33:21 #24 0x3901754 in Run base/run_loop.cc:35:3 #25 0x38bd3b4 in ?? base/message_loop/message_loop.cc:293:3 Uninitialized value was created by a heap allocation #0 0x690ec2 in operator new(unsigned long) ??:0 #1 0x490c7b6 in GrGLCreateNullInterface third_party/skia/src/gpu/gl/GrGLCreateNullInterface.cpp:614:57 #2 0x4244876 in SkNullGLContext third_party/skia/src/gpu/gl/SkNullGLContext.cpp:22:16 #3 0x4244876 in Create third_party/skia/src/gpu/gl/SkNullGLContext.cpp:13:0 #4 0x3846473 in GrContext cc/test/test_context_provider.cc:115:44 #5 0x34c0a0f in CanUseGpuRasterization cc/trees/layer_tree_host_impl.cc:1722:8 #6 0x34c0a0f in UpdateGpuRasterizationStatus cc/trees/layer_tree_host_impl.cc:1757:0 #7 0x34cb1c6 in InitializeRenderer cc/trees/layer_tree_host_impl.cc:2314:3 #8 0x38115ca in ?? cc/test/layer_tree_test.cc:292:20 #9 0x360e149 in InitializeOutputSurfaceOnImpl cc/trees/proxy_impl.cc:137:18 #10 0x35a5302 in Run\u003Ccc::OutputSurface *const &> base/bind_internal.h:181:12 #11 0x35a5302 in MakeItSo\u003Cbase::WeakPtr\u003Ccc::ProxyImpl>, cc::OutputSurface *const &> base/bind_internal.h:314:0 #12 0x35a5302 in Run base/bind_internal.h:352:0 #13 0x39dc6b4 in Run base/callback.h:397:12 #14 0x39dc6b4 in RunTask base/debug/task_annotator.cc:51:0 #15 0x38bef4f in RunTask base/message_loop/message_loop.cc:476:3 #16 0x38c0777 in DeferOrRunPendingTask base/message_loop/message_loop.cc:485:5 #17 0x38c1265 in DoWork base/message_loop/message_loop.cc:597:13 #18 0x38cd333 in Run base/message_loop/message_pump_default.cc:33:21 #19 0x3901754 in Run base/run_loop.cc:35:3 #20 0x38bd3b4 in ?? base/message_loop/message_loop.cc:293:3 #21 0x394d07c in ThreadMain base/threading/thread.cc:254:3 #22 0x394148f in ThreadFunc base/threading/platform_thread_posix.cc:68:3 #23 0x7fe2cb082e99 in start_thread /build/eglibc-rrybNj/eglibc-2.15/nptl/pthread_create.c:308:0
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817793002/1
Message was sent while issue was closed.
Description was changed from ========== Fix uninitialized fCurrProgramID in GrGLCreateNullInterface TBR=bsalomon@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Fix uninitialized fCurrProgramID in GrGLCreateNullInterface TBR=bsalomon@google.com,robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/ba73ad0f3a6d9d505cae08e4f3cc5d2d6b9b1501 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ba73ad0f3a6d9d505cae08e4f3cc5d2d6b9b1501
Message was sent while issue was closed.
On 2016/03/19 20:07:18, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://skia.googlesource.com/skia/+/ba73ad0f3a6d9d505cae08e4f3cc5d2d6b9b1501 lgtm, thanks Florin! |
|||||||||||||||||||||||||||||||||||||||||||||||
