Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 181773008: Pass the proper RenderFrameHost to observers. (Closed)

Created:
6 years, 9 months ago by nasko
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Visibility:
Public.

Description

Pass the proper RenderFrameHost to observers. BUG=347339 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
jam
lgtm
6 years, 9 months ago (2014-02-27 21:36:09 UTC) #1
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 9 months ago (2014-02-27 21:44:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/181773008/1
6 years, 9 months ago (2014-02-27 21:46:12 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-02-27 22:18:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg
6 years, 9 months ago (2014-02-27 22:18:34 UTC) #5
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 9 months ago (2014-02-27 22:20:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/181773008/1
6 years, 9 months ago (2014-02-27 22:22:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/181773008/1
6 years, 9 months ago (2014-02-28 01:06:39 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 01:53:39 UTC) #9
Message was sent while issue was closed. 
Change committed as 254009

Powered by Google App Engine
This is Rietveld 408576698