third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp - Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-idle-callback

Patch Set: Address comments, add mapToVisibleRectInContainerSpace test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.h ('K') | « third_party/WebKit/Source/core/layout/LayoutFlowThread.h ('k') | third_party/WebKit/Source/core/layout/LayoutInline.h » ('j') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

index 1cdd6fba6813e0d7198c86ab7eaaf9b65333ec9e..61a416340641fda2e73e94fabe8ce2ca841fa915 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFlowThread.cpp

@@ -97,7 +97,7 @@ void LayoutFlowThread::validateColumnSets()

generateColumnSetIntervalTree();

}

-void LayoutFlowThread::mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* ancestor, LayoutRect& rect, const PaintInvalidationState* paintInvalidationState) const

+bool LayoutFlowThread::mapToVisibleRectInAncestorSpace(const LayoutBoxModelObject* ancestor, LayoutRect& rect, const PaintInvalidationState* paintInvalidationState, VisibleRectFlags visibleRectFlags) const

{

ASSERT(ancestor != this); // A flow thread should never be an invalidation container.

// |rect| is a layout rectangle, where the block direction coordinate is flipped for writing

@@ -106,7 +106,7 @@ void LayoutFlowThread::mapToVisibleRectInAncestorSpace(const LayoutBoxModelObjec

flipForWritingMode(rect);

rect = fragmentsBoundingBox(rect);

flipForWritingMode(rect);

- LayoutBlockFlow::mapToVisibleRectInAncestorSpace(ancestor, rect, paintInvalidationState);

+ return LayoutBlockFlow::mapToVisibleRectInAncestorSpace(ancestor, rect, paintInvalidationState, visibleRectFlags);

}

void LayoutFlowThread::layout()