third_party/WebKit/Source/core/dom/IntersectionObservation.h - Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.h

Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-idle-callback

Patch Set: Address comments, add mapToVisibleRectInContainerSpace test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/intersection-observer/same-document-zero-size-target-expected.txt ('k') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/IntersectionObservation.h

diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.h b/third_party/WebKit/Source/core/dom/IntersectionObservation.h

index 394146dda16c7b78f39b2c9196e47b4d3d72e46d..0d50498d2791bebefddcb68f7a69c77da5dd994e 100644

--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.h

+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.h

@@ -24,6 +24,7 @@ public:

LayoutRect targetRect;

LayoutRect intersectionRect;

LayoutRect rootRect;

+ bool doesIntersect;

};

IntersectionObserver& observer() const { return *m_observer; }

@@ -39,9 +40,10 @@ public:

private:

void applyRootMargin(LayoutRect&) const;

+ void initializeGeometry(IntersectionGeometry&) const;

void initializeTargetRect(LayoutRect&) const;

void initializeRootRect(LayoutRect&) const;

- void clipToRoot(LayoutRect&, const LayoutRect&) const;

+ void clipToRoot(IntersectionGeometry&) const;

void mapTargetRectToTargetFrameCoordinates(LayoutRect&) const;

void mapRootRectToRootFrameCoordinates(LayoutRect&) const;

void mapRootRectToTargetFrameCoordinates(LayoutRect&) const;