third_party/WebKit/Source/web/WebPluginContainerImpl.cpp - Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-idle-callback

Patch Set: compiler warning fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

index 08a0799da30733a8419d489946114b62866e9fd5..18d0f1449b14bdd4335303e70161f82e883c716b 100644

--- a/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPluginContainerImpl.cpp

@@ -943,7 +943,7 @@ void WebPluginContainerImpl::computeClipRectsForPlugin(

FloatRect frameRectInOwnerElementSpace = box->absoluteToLocalQuad(FloatRect(frameRect()), UseTransforms).boundingBox();

LayoutRect unclippedAbsoluteRect(frameRectInOwnerElementSpace);

- box->mapToVisibleRectInAncestorSpace(rootView, unclippedAbsoluteRect, nullptr);

+ box->mapToVisibleRectInAncestorSpace(rootView, unclippedAbsoluteRect, nullptr, false);

// The frameRect is already in absolute space of the local frame to the plugin.

windowRect = frameRect();

« third_party/WebKit/Source/platform/geometry/LayoutRect.cpp ('K') | « third_party/WebKit/Source/platform/geometry/LayoutRect.cpp ('k') | no next file » | no next file with comments »