third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp - Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

Issue 1817693002: Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace (Closed) Base URL: https://chromium.googlesource.com/chromium/src@intersection-observer-idle-callback

Patch Set: compiler warning fix Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.h ('K') | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutReplaced.cpp » ('j') | third_party/WebKit/Source/platform/geometry/LayoutRect.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

index ca38e7dbde378cc0ca7de8fdf33e9bedec7527f2..61a4dd6ac110834bed9b66d1e232dff94b63ce3b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

@@ -118,7 +118,7 @@ TEST_F(LayoutObjectTest, MapToVisibleRectInAncestorSpace)

container->setScrollTop(LayoutUnit(50));

LayoutRect rect(0, 60, 20, 20);

- text->mapToVisibleRectInAncestorSpace(container, rect, nullptr);

+ text->mapToVisibleRectInAncestorSpace(container, rect, nullptr, false);

EXPECT_TRUE(rect == LayoutRect(0, 10, 20, 20));

}