Support edge-inclusive intersections in mapToVisibleRectInAncestorSpace

third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutObject.h"
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 100 matching lines @@
     setBodyInnerHTML(
         "<div id='container' style='overflow: scroll; will-change: transform; width: 50px; height: 50px'>"
         "  <span><img style='width: 20px; height: 100px'></span>"
         "  text text text text text text text"
         "</div>");
     LayoutBlock* container = toLayoutBlock(getLayoutObjectByElementId("container"));
     LayoutText* text = toLayoutText(container->lastChild());
 
     container->setScrollTop(LayoutUnit(50));
     LayoutRect rect(0, 60, 20, 20);
-    text->mapToVisibleRectInAncestorSpace(container, rect, nullptr);
+    EXPECT_TRUE(text->mapToVisibleRectInAncestorSpace(container, rect, nullptr));
     EXPECT_TRUE(rect == LayoutRect(0, 10, 20, 20));
+
+    rect = LayoutRect(0, 60, 20, 0);
+    EXPECT_TRUE(text->mapToVisibleRectInAncestorSpace(container, rect, nullptr, EdgeInclusive));
+    EXPECT_TRUE(rect == LayoutRect(0, 10, 20, 0));

[chrishtr, 2016/03/22 19:54:26]

Why does this example yield a zero-area rect? Isn't it a repeat of the example
on
line 121 with a weaker test?

Also, this amount of testing is a little weak sauce. e.g. not tested for
iframes, etc.
Can you add those?

[szager1, 2016/03/23 23:26:59]

No; the input rect has zero height, so the result should also be zero area.
grumble grumble

[chrishtr, 2016/03/24 21:18:43]

?

 }
 
 } // namespace blink