Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1817683002: Set the project in codereview settings (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
nodir, martiniss
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M codereview.settings View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL. Does it need to be landed to work?
4 years, 9 months ago (2016-03-18 23:45:44 UTC) #2
nodir
lgtm +martiniss any idea why this fails?
4 years, 9 months ago (2016-03-19 00:11:20 UTC) #4
dsinclair
Committed patchset #1 (id:1) manually as 645f78b2fc4e6235374ef17cd83a94e26868b486 (presubmit successful).
4 years, 9 months ago (2016-03-19 00:12:16 UTC) #6
dsinclair
On 2016/03/19 00:11:20, nodir wrote: > lgtm > > +martiniss any idea why this fails? ...
4 years, 9 months ago (2016-03-19 00:14:19 UTC) #7
martiniss
4 years, 9 months ago (2016-03-19 00:36:13 UTC) #8
Message was sent while issue was closed.
On 2016/03/19 at 00:14:19, dsinclair wrote:
> On 2016/03/19 00:11:20, nodir wrote:
> > lgtm
> > 
> > +martiniss any idea why this fails?
> 
> Landed this and rebased https://codereview.chromium.org/1809193002/ on top and
the jobs fail in the same way.

Looking; I think I can figure this out.

Powered by Google App Engine
This is Rietveld 408576698