Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 1817633002: Make FreeType usable on Windows. (Closed)

Created:
4 years, 9 months ago by caryclark
Modified:
4 years, 9 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make FreeType usable on Windows. Add missing functionality so that pdfium can use FreeType from Windows. Add an empty custom font manager so pdfium can use FreeType without any local fonts. R=bungeman@google.com Committed: https://skia.googlesource.com/skia/+/fe7ada7f0dc109cc8cf220607c2bd8c09bd1fa5e

Patch Set 1 #

Patch Set 2 : make windows port use freetype #

Patch Set 3 : whitespace fix #

Patch Set 4 : add missing file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -16 lines) Patch
M include/ports/SkFontMgr_custom.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkAdvancedTypefaceMetrics.cpp View 1 2 3 chunks +7 lines, -9 lines 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 3 chunks +4 lines, -3 lines 0 comments Download
M src/ports/SkFontMgr_custom.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
A + src/ports/SkFontMgr_custom_empty_factory.cpp View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817633002/60001
4 years, 9 months ago (2016-03-18 21:35:10 UTC) #5
caryclark
4 years, 9 months ago (2016-03-18 21:35:28 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 21:51:54 UTC) #8
bungeman-skia
lgtm
4 years, 9 months ago (2016-03-18 22:28:27 UTC) #10
caryclark
4 years, 9 months ago (2016-03-21 11:18:30 UTC) #12
reed1
api lgtm
4 years, 9 months ago (2016-03-21 13:15:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817633002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817633002/60001
4 years, 9 months ago (2016-03-21 13:45:38 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 13:55:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/fe7ada7f0dc109cc8cf220607c2bd8c09bd1fa5e

Powered by Google App Engine
This is Rietveld 408576698