Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: third_party/WebKit/Source/core/paint/ReplacedPainter.cpp

Issue 1817623004: When the SVG element is 'visible', the SVG element is not shown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/ReplacedPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp b/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp
index 6f1c65510f542981c346be17e0dba4c2985e314d..93e1b1f2962050548c5fe07d23ca71cba39fe082 100644
--- a/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ReplacedPainter.cpp
@@ -25,8 +25,11 @@ static bool shouldApplyViewportClip(const LayoutReplaced& layoutReplaced)
void ReplacedPainter::paint(const PaintInfo& paintInfo, const LayoutPoint& paintOffset)
{
LayoutPoint adjustedPaintOffset = paintOffset + m_layoutReplaced.location();
- if (!shouldPaint(paintInfo, adjustedPaintOffset))
+ if (!shouldPaint(paintInfo, adjustedPaintOffset)) {
+ if (m_layoutReplaced.isSVGRoot() && m_layoutReplaced.style()->visibility() != VISIBLE)
fs 2016/03/21 16:07:58 I _think_ that clipping from 'overflow' should sti
hyunjunekim2 2016/03/23 14:19:33 Could you checkPS13? Added more tests. Thank you.
+ m_layoutReplaced.paintReplaced(paintInfo, adjustedPaintOffset);
return;
+ }
LayoutRect borderRect(adjustedPaintOffset, m_layoutReplaced.size());

Powered by Google App Engine
This is Rietveld 408576698