Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1817623003: Adjust status files for product mode to skip tests that require checked mode as we do not support t… (Closed)

Created:
4 years, 9 months ago by siva
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Adjust status files for product mode to skip tests that require checked mode as we do not support the flags --enable_asserts and --enable_type_checks in product mode. tools/test.py -mproduct -cdart2app -rdart_product should run clean after this CL R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/8364da0e1b7f5181d4197021c7f40c0c2bb65420

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M runtime/tests/vm/vm.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +13 lines, -1 line 0 comments Download
M tests/standalone/standalone.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
siva
4 years, 9 months ago (2016-03-18 22:43:33 UTC) #2
rmacnak
lgtm
4 years, 9 months ago (2016-03-21 17:26:29 UTC) #4
siva
4 years, 9 months ago (2016-03-21 18:09:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8364da0e1b7f5181d4197021c7f40c0c2bb65420 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698