MacViews: draw Mac combobox arrows

ui/native_theme/common_theme.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/native_theme/common_theme.h"
 
 #include "base/logging.h"
 #include "third_party/skia/include/core/SkCanvas.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/resource/resource_bundle.h"
@@ skipping 387 matching lines @@
       return kThrobberLightColor;
 
     case NativeTheme::kColorId_NumColors:
       break;
   }
 
   NOTREACHED();
   return gfx::kPlaceholderColor;
 }
 
-gfx::Size CommonThemeGetPartSize(NativeTheme::Part part,

[tapted, 2016/04/05 08:45:01]

remove the declaration in common_theme.h 

[Elly Fong-Jones, 2016/04/05 20:04:24]

Done.

-                                 NativeTheme::State state,
-                                 const NativeTheme::ExtraParams& extra) {
-  gfx::Size size;
-  switch (part) {
-    case NativeTheme::kComboboxArrow:
-      return ui::ResourceBundle::GetSharedInstance().GetImageNamed(
-          IDR_MENU_DROPARROW).Size();
-
-    default:
-      break;
-  }
-
-  return size;
-}
-
 void CommonThemePaintComboboxArrow(SkCanvas* canvas, const gfx::Rect& rect) {

[tapted, 2016/04/05 08:45:02]

Can this method (and the declaration) be removed? Pretty sure nothing calls it
now

[Elly Fong-Jones, 2016/04/05 20:04:24]

Done.

   gfx::ImageSkia* arrow = ui::ResourceBundle::GetSharedInstance().
       GetImageSkiaNamed(IDR_MENU_DROPARROW);
   CommonThemeCreateCanvas(canvas)->DrawImageInt(*arrow, rect.x(), rect.y());
 }
 
 void CommonThemePaintMenuItemBackground(
     const NativeTheme* theme,
     SkCanvas* canvas,
     NativeTheme::State state,
     const gfx::Rect& rect,
@@ skipping 25 matching lines @@
 scoped_ptr<gfx::Canvas> CommonThemeCreateCanvas(SkCanvas* sk_canvas) {
   // TODO(pkotwicz): Do something better and don't infer device
   // scale factor from canvas scale.
   SkMatrix m = sk_canvas->getTotalMatrix();
   float device_scale = static_cast<float>(SkScalarAbs(m.getScaleX()));
   return make_scoped_ptr(new gfx::Canvas(skia::SharePtr(sk_canvas),
                                          device_scale));
 }
 
 }  // namespace ui