Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 18176005: add point of interest API (Closed)

Created:
7 years, 5 months ago by Zach Reizner
Modified:
7 years, 5 months ago
Reviewers:
djsollen, bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : constant zero buffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -31 lines) Patch
M experimental/skpdiff/SkCLImageDiffer.h View 1 chunk +4 lines, -7 lines 0 comments Download
M experimental/skpdiff/SkCLImageDiffer.cpp View 1 8 chunks +53 lines, -9 lines 0 comments Download
M experimental/skpdiff/SkImageDiffer.h View 2 chunks +24 lines, -2 lines 0 comments Download
M experimental/skpdiff/SkImageDiffer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M experimental/skpdiff/SkPMetric.h View 2 chunks +6 lines, -1 line 0 comments Download
M experimental/skpdiff/SkPMetric.cpp View 6 chunks +18 lines, -5 lines 0 comments Download
M experimental/skpdiff/diff_pixels.cl View 2 chunks +4 lines, -2 lines 0 comments Download
M experimental/skpdiff/main.cpp View 4 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Zach Reizner
7 years, 5 months ago (2013-06-28 14:13:18 UTC) #1
bsalomon
Is there some context for the POIs? Are we going to highlight them in a ...
7 years, 5 months ago (2013-06-28 14:47:17 UTC) #2
Zach Reizner
Yes. Depending on what type of diff is performed, the UI will choose how best ...
7 years, 5 months ago (2013-06-28 14:52:58 UTC) #3
bsalomon
Thanks for the explanation about what the POIs are for. https://codereview.chromium.org/18176005/diff/1/experimental/skpdiff/SkCLImageDiffer.cpp File experimental/skpdiff/SkCLImageDiffer.cpp (right): https://codereview.chromium.org/18176005/diff/1/experimental/skpdiff/SkCLImageDiffer.cpp#newcode173 ...
7 years, 5 months ago (2013-06-28 14:56:37 UTC) #4
Zach Reizner
7 years, 5 months ago (2013-06-28 15:27:15 UTC) #5
bsalomon
On 2013/06/28 15:27:15, Zach Reizner wrote: lgtm
7 years, 5 months ago (2013-06-28 15:37:24 UTC) #6
Zach Reizner
7 years, 5 months ago (2013-06-28 16:27:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 manually as r9806 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698