Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1817583003: Enable GPU Rasterization for content with any author defined viewport. (Closed)

Created:
4 years, 9 months ago by vmiura
Modified:
4 years, 9 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable GPU Rasterization for content with any author defined viewport. BUG=591179 Committed: https://crrev.com/b338ee0b3125007b94854e44ed7b6df820c72a75 Cr-Commit-Position: refs/heads/master@{#382394}

Patch Set 1 #

Patch Set 2 : Updated unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M third_party/WebKit/Source/core/dom/ViewportDescription.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ViewportTest.cpp View 1 2 chunks +20 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/web/tests/data/viewport/viewport-gpu-rasterization-disabled-without-viewport.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
D third_party/WebKit/Source/web/tests/data/viewport/viewport-inferred-values-do-not-trigger-gpu-rasterization.html View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
vmiura
PTAL
4 years, 9 months ago (2016-03-19 00:51:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817583003/1
4 years, 9 months ago (2016-03-19 00:52:48 UTC) #4
pdr.
Thank you so much Victor! LGTM
4 years, 9 months ago (2016-03-19 01:43:20 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/197819)
4 years, 9 months ago (2016-03-19 01:58:24 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817583003/20001
4 years, 9 months ago (2016-03-19 02:24:00 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-19 03:24:34 UTC) #11
aelias_OOO_until_Jul13
lgtm
4 years, 9 months ago (2016-03-21 01:02:40 UTC) #12
chrishtr
lgtm
4 years, 9 months ago (2016-03-21 18:06:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817583003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817583003/20001
4 years, 9 months ago (2016-03-21 20:06:35 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-21 21:25:29 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b338ee0b3125007b94854e44ed7b6df820c72a75 Cr-Commit-Position: refs/heads/master@{#382394}
4 years, 9 months ago (2016-03-21 21:26:37 UTC) #20
vmiura
4 years, 8 months ago (2016-04-06 18:58:41 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1868563003/ by vmiura@chromium.org.

The reason for reverting is: Reverting until we can debug memory health
regressions on WebView.

BUG=596881.

Powered by Google App Engine
This is Rietveld 408576698