Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1817573002: [md] Give each infobar its own layer. (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[md] Give each infobar its own layer. This is necessary so latter bars can draw their arrow above the previous bar. This is similar to crbug.com/589771 , the fix for which only worked for the first infobar. This also fixes hit testing which was broken when there was a floating bookmark bar below the infobar. BUG=592727, 593640 Review URL: https://codereview.chromium.org/1767363002 Cr-Commit-Position: refs/heads/master@{#381267} (cherry picked from commit 966e15221d7c60c7922d94af047a6663cb175c1e) Committed: https://chromium.googlesource.com/chromium/src/+/f4ee21f5b2c49c57ca897b85c1ed67b375ad2603

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M chrome/browser/ui/views/infobars/infobar_container_view.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
Evan Stade
4 years, 9 months ago (2016-03-18 18:40:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f4ee21f5b2c49c57ca897b85c1ed67b375ad2603.

Powered by Google App Engine
This is Rietveld 408576698