Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java

Issue 1817553002: Add host resolver rules experimental flag for Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix error caused by conflicting change, and rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
index c55b9744c7cbba1d14b154a1fa2f61bfa909907b..29cdec0418830a4d5690052c8f6177a153729f67 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java
@@ -21,6 +21,7 @@ import org.chromium.base.test.util.Feature;
import org.chromium.net.CronetEngine.UrlRequestInfo;
import org.chromium.net.TestUrlRequestCallback.ResponseStep;
import org.chromium.net.test.EmbeddedTestServer;
+import org.json.JSONObject;
import java.io.BufferedReader;
import java.io.File;
@@ -41,6 +42,7 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
"http://mock.failed.request/-2";
private static final String MOCK_CRONET_TEST_SUCCESS_URL =
"http://mock.http/success.txt";
+ private static final String RESOLVER_TEST_HOSTNAME = "some-weird-hostname";
pauljensen 2016/04/07 16:29:15 if this is just used for one test, how about we mo
mgersh 2016/06/08 18:31:14 Done.
private EmbeddedTestServer mTestServer;
private String mUrl;
@@ -1019,4 +1021,25 @@ public class CronetUrlRequestContextTest extends CronetTestBase {
assertTrue(loader.wasCalled());
}
}
+
+ @SmallTest
+ @Feature({"Cronet"})
+ public void testHostResolverRules() throws Exception {
+ CronetEngine.Builder cronetEngineBuilder = new CronetEngine.Builder(getContext());
+ JSONObject hostResolverRules = new JSONObject().put(
+ "host_resolver_rules", "MAP " + RESOLVER_TEST_HOSTNAME + " 127.0.0.1:8000");
pauljensen 2016/04/07 16:29:15 I think port 8000 is the python test server runnin
mgersh 2016/06/08 18:31:13 Done, with some fiddling to get the right parts of
+ JSONObject experimentalOptions =
+ new JSONObject().put("HostResolverRules", hostResolverRules);
+ cronetEngineBuilder.setExperimentalOptions(experimentalOptions.toString());
+
+ mTestFramework =
+ startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, cronetEngineBuilder);
+ TestUrlRequestCallback callback = new TestUrlRequestCallback();
+ UrlRequest.Builder urlRequestBuilder =
+ new UrlRequest.Builder("http://" + RESOLVER_TEST_HOSTNAME, callback,
pauljensen 2016/04/07 16:29:15 can this also use mUrl?
mgersh 2016/06/08 18:31:14 Done.
+ callback.getExecutor(), mTestFramework.mCronetEngine);
+ urlRequestBuilder.build().start();
+ callback.blockForDone();
+ assertEquals(200, callback.mResponseInfo.getHttpStatusCode());
+ }
}
« no previous file with comments | « no previous file | components/cronet/url_request_context_config.cc » ('j') | components/cronet/url_request_context_config.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698