components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java - Issue 1817553002: Add host resolver rules experimental flag for Cronet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java

Issue 1817553002: Add host resolver rules experimental flag for Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: delete unused definitions, rebase, and fix test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java ('k') | components/cronet/android/test/native_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java

index 2303c50f81495fc436aa4b14a1834c1438c0da9c..b138195b4e60c0ac1e5a08e98d083eb3d4c2bf04 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/QuicUploadTest.java

@@ -10,6 +10,7 @@ import org.chromium.base.test.util.Feature;

import org.chromium.net.CronetEngine;

import org.chromium.net.CronetTestBase;

import org.chromium.net.CronetTestFramework;

+import org.chromium.net.CronetTestUtil;

import org.chromium.net.QuicTestServer;

import org.json.JSONObject;

@@ -37,7 +38,10 @@ public class QuicUploadTest extends CronetTestBase {

builder.enableQuic(true);

JSONObject quicParams =

new JSONObject().put("host_whitelist", QuicTestServer.getServerHost());

- JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);

+ JSONObject hostResolverParams = CronetTestUtil.generateHostResolverRules();

+ JSONObject experimentalOptions = new JSONObject()

+ .put("QUIC", quicParams)

+ .put("HostResolverRules", hostResolverParams);

builder.setExperimentalOptions(experimentalOptions.toString());

builder.addQuicHint(QuicTestServer.getServerHost(), QuicTestServer.getServerPort(),

@@ -46,7 +50,6 @@ public class QuicUploadTest extends CronetTestBase {

builder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());

mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);

- registerHostResolver(mTestFramework);

}

@SmallTest