Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java

Issue 1817553002: Add host resolver rules experimental flag for Cronet (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: delete unused definitions, rebase, and fix test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
index 3298f00f82a943976558ce734b06cf08aef233e3..2cf6fb85e3d46a7d9ca34fa506401fd0e6c7ac6d 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java
@@ -54,7 +54,10 @@ public class QuicTest extends CronetTestBase {
.put("migrate_sessions_on_network_change", false)
.put("migrate_sessions_early", false)
.put("race_cert_verification", true);
- JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);
+ JSONObject hostResolverParams = CronetTestUtil.generateHostResolverRules();
+ JSONObject experimentalOptions = new JSONObject()
+ .put("QUIC", quicParams)
+ .put("HostResolverRules", hostResolverParams);
mBuilder.setExperimentalOptions(experimentalOptions.toString());
mBuilder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());
mBuilder.setStoragePath(CronetTestFramework.getTestStorage(getContext()));
@@ -75,7 +78,6 @@ public class QuicTest extends CronetTestBase {
String[] commandLineArgs = {
CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LibraryInitType.LEGACY};
mTestFramework = new CronetTestFramework(null, commandLineArgs, getContext(), mBuilder);
- registerHostResolver(mTestFramework, true);
String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
HashMap<String, String> headers = new HashMap<String, String>();
@@ -101,7 +103,6 @@ public class QuicTest extends CronetTestBase {
@OnlyRunNativeCronet
public void testQuicLoadUrl() throws Exception {
mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, mBuilder);
- registerHostResolver(mTestFramework);
String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
TestUrlRequestCallback callback = new TestUrlRequestCallback();
@@ -144,11 +145,13 @@ public class QuicTest extends CronetTestBase {
builder.enableHttpCache(CronetEngine.Builder.HTTP_CACHE_DISK, 1000 * 1024);
builder.enableQuic(true);
JSONObject quicParams = new JSONObject().put("host_whitelist", "test.example.com");
- JSONObject experimentalOptions = new JSONObject().put("QUIC", quicParams);
+ JSONObject hostResolverParams = CronetTestUtil.generateHostResolverRules();
+ JSONObject experimentalOptions = new JSONObject()
+ .put("QUIC", quicParams)
+ .put("HostResolverRules", hostResolverParams);
builder.setExperimentalOptions(experimentalOptions.toString());
builder.setMockCertVerifierForTesting(QuicTestServer.createMockCertVerifier());
mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, builder);
- registerHostResolver(mTestFramework);
TestUrlRequestCallback callback2 = new TestUrlRequestCallback();
requestBuilder = new UrlRequest.Builder(
quicURL, callback2, callback2.getExecutor(), mTestFramework.mCronetEngine);
@@ -180,7 +183,6 @@ public class QuicTest extends CronetTestBase {
@SuppressWarnings("deprecation")
public void testRealTimeNetworkQualityObservationsWithQuic() throws Exception {
mTestFramework = startCronetTestFrameworkWithUrlAndCronetEngineBuilder(null, mBuilder);
- registerHostResolver(mTestFramework);
String quicURL = QuicTestServer.getServerURL() + "/simple.txt";
ConditionVariable waitForThroughput = new ConditionVariable();

Powered by Google App Engine
This is Rietveld 408576698