Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1817543002: Revert of switch patheffects over to sk_sp (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
Reviewers:
caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of switch patheffects over to sk_sp (patchset #5 id:80001 of https://codereview.chromium.org/1813553005/ ) Reason for revert: some build breaks, possibly related to paint having to know what a patheffect is Original issue's description: > switch patheffects over to sk_sp > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1813553005 > > Committed: https://skia.googlesource.com/skia/+/9fbee18f691a0afed1e38a851048ce06063505ed TBR=caryclark@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/f28ad894272018fd2855e3f77ea1236ea0cce1c0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -268 lines) Patch
M bench/DashBench.cpp View 11 chunks +14 lines, -11 lines 0 comments Download
M gm/arcto.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bug530095.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M gm/dashcircle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/dashcubics.cpp View 1 chunk +18 lines, -16 lines 0 comments Download
M gm/dashing.cpp View 6 chunks +7 lines, -6 lines 0 comments Download
M gm/pathcontourstart.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M gm/patheffects.cpp View 4 chunks +13 lines, -11 lines 0 comments Download
M gm/strokes.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/stroketext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/textbloblooper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/texteffects.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkPaint.h View 1 chunk +1 line, -6 lines 0 comments Download
M include/core/SkPathEffect.h View 6 chunks +18 lines, -33 lines 0 comments Download
M include/effects/Sk1DPathEffect.h View 1 chunk +1 line, -7 lines 0 comments Download
M include/effects/Sk2DPathEffect.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/effects/SkArcToPathEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/effects/SkCornerPathEffect.h View 1 chunk +1 line, -9 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +1 line, -7 lines 0 comments Download
M include/effects/SkDiscretePathEffect.h View 1 chunk +1 line, -5 lines 0 comments Download
M samplecode/ClockFaceView.cpp View 3 chunks +6 lines, -5 lines 0 comments Download
M samplecode/SampleAll.cpp View 7 chunks +12 lines, -9 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 2 chunks +21 lines, -17 lines 0 comments Download
M samplecode/SamplePath.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M samplecode/SamplePathEffects.cpp View 3 chunks +21 lines, -16 lines 0 comments Download
M samplecode/SampleSlides.cpp View 9 chunks +21 lines, -19 lines 0 comments Download
M src/animator/SkDrawPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkPaint.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M src/core/SkPathEffect.cpp View 4 chunks +33 lines, -13 lines 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkArcToPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkCornerPathEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkDashPathEffect.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M src/effects/SkLayerDrawLooper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/xps/SkXPSDevice.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/AsADashTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/DrawPathTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M tests/GpuDrawPathTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/PictureTest.cpp View 3 chunks +5 lines, -3 lines 0 comments Download
M tools/debugger/SkDrawCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of switch patheffects over to sk_sp
4 years, 9 months ago (2016-03-18 17:17:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817543002/1
4 years, 9 months ago (2016-03-18 17:17:11 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 17:17:31 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f28ad894272018fd2855e3f77ea1236ea0cce1c0

Powered by Google App Engine
This is Rietveld 408576698