Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1817533002: Make rebase_path() aware of Windows drive letter capitalization (Closed)

Created:
4 years, 9 months ago by Tomasz Moniuszko
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make rebase_path() aware of Windows drive letter capitalization Make sure rebase_path() supports both capital and non-capital Windows path drive letters. It's unable to find common path prefix otherwise. BUG=596072 Committed: https://crrev.com/01a402cd6fb6873e61d2faa269b6b991d307635e Cr-Commit-Position: refs/heads/master@{#382532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/gn/filesystem_utils.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M tools/gn/filesystem_utils_unittest.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Tomasz Moniuszko
4 years, 9 months ago (2016-03-18 16:10:06 UTC) #2
brettw
lgtm
4 years, 9 months ago (2016-03-21 23:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817533002/1
4 years, 9 months ago (2016-03-22 08:00:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 08:30:23 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 08:33:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01a402cd6fb6873e61d2faa269b6b991d307635e
Cr-Commit-Position: refs/heads/master@{#382532}

Powered by Google App Engine
This is Rietveld 408576698