Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp

Issue 1817523003: DevTools: Select max resource size in NetworkResourcesData depending on device capabilities. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
diff --git a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
index 925d64c1d0f73111288a1b6ac7d41b57c92d295d..71a8816c030cbdcb323c6131ba92ddb448a80411 100644
--- a/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
+++ b/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
@@ -34,17 +34,8 @@
#include "platform/SharedBuffer.h"
#include "platform/network/ResourceResponse.h"
-namespace {
-// 100MB
-static size_t maximumResourcesContentSize = 100 * 1000 * 1000;
-
-// 10MB
-static size_t maximumSingleResourceContentSize = 10 * 1000 * 1000;
-}
-
namespace blink {
-
PassRefPtrWillBeRawPtr<XHRReplayData> XHRReplayData::create(ExecutionContext* executionContext, const AtomicString& method, const KURL& url, bool async, PassRefPtr<EncodedFormData> formData, bool includeCredentials)
{
return adoptRefWillBeNoop(new XHRReplayData(executionContext, method, url, async, formData, includeCredentials));
@@ -150,10 +141,10 @@ size_t NetworkResourcesData::ResourceData::decodeDataToContent()
}
// NetworkResourcesData
-NetworkResourcesData::NetworkResourcesData()
+NetworkResourcesData::NetworkResourcesData(size_t totalBufferSize, size_t resourceBufferSize)
: m_contentSize(0)
- , m_maximumResourcesContentSize(maximumResourcesContentSize)
- , m_maximumSingleResourceContentSize(maximumSingleResourceContentSize)
+ , m_maximumResourcesContentSize(totalBufferSize)
+ , m_maximumSingleResourceContentSize(resourceBufferSize)
{
}
@@ -335,6 +326,8 @@ Vector<String> NetworkResourcesData::removeResource(Resource* cachedResource)
void NetworkResourcesData::clear(const String& preservedLoaderId)
{
+ if (!m_requestIdToResourceDataMap.size())
+ return;
m_requestIdsDeque.clear();
m_contentSize = 0;
@@ -352,8 +345,6 @@ void NetworkResourcesData::clear(const String& preservedLoaderId)
m_requestIdToResourceDataMap.swap(preservedMap);
m_reusedXHRReplayDataRequestIds.clear();
- m_maximumResourcesContentSize = maximumResourcesContentSize;
- m_maximumSingleResourceContentSize = maximumSingleResourceContentSize;
}
void NetworkResourcesData::setResourcesDataSizeLimits(size_t resourcesContentSize, size_t singleResourceContentSize)

Powered by Google App Engine
This is Rietveld 408576698