Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 18175008: Skip the TIMESTAMP file. (Closed)

Created:
7 years, 5 months ago by scroggo
Modified:
7 years, 5 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Skip the TIMESTAMP file. Allows run_decoding_tests.py to pass the name of the folder, so Android will not fail on account of the long adb command. R=borenet@google.com Committed: https://code.google.com/p/skia/source/detail?r=9817

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M tools/skimage_main.cpp View 1 2 chunks +20 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
scroggo
7 years, 5 months ago (2013-06-28 19:46:51 UTC) #1
borenet
LGTM to get the bots fixed, but I'd prefer a more robust solution... https://codereview.chromium.org/18175008/diff/1/tools/skimage_main.cpp File ...
7 years, 5 months ago (2013-06-28 19:50:38 UTC) #2
scroggo
https://codereview.chromium.org/18175008/diff/1/tools/skimage_main.cpp File tools/skimage_main.cpp (right): https://codereview.chromium.org/18175008/diff/1/tools/skimage_main.cpp#newcode502 tools/skimage_main.cpp:502: return !basename.startsWith("TIMESTAMP"); On 2013/06/28 19:50:38, borenet wrote: > How ...
7 years, 5 months ago (2013-06-28 20:00:10 UTC) #3
borenet
LGTM https://codereview.chromium.org/18175008/diff/5001/tools/skimage_main.cpp File tools/skimage_main.cpp (right): https://codereview.chromium.org/18175008/diff/5001/tools/skimage_main.cpp#newcode499 tools/skimage_main.cpp:499: }; I agree that this is cumbersome, but ...
7 years, 5 months ago (2013-06-28 20:02:02 UTC) #4
scroggo
7 years, 5 months ago (2013-06-28 20:04:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r9817 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698