Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 1817483002: [Password Manager] Presave the form with generated password till successful login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index 6b9023418be5f93577539b4f3b9f6aa379022611..83b91c00f76797737475cc7a039c21328b9f6680 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -84,7 +84,12 @@ class PasswordManager : public LoginModel {
void GenerationAvailableForForm(const autofill::PasswordForm& form);
+ // Presaves and updates the form with generated password.
dvadym 2016/04/06 12:44:23 I'm not sure that it's correct to write presave to
kolos1 2016/04/07 13:05:18 We should write 'presave'.
+ void OnPresaveGeneratedPassword(const autofill::PasswordForm& password_form);
+ void OnUpdatePresavedPassword(const autofill::PasswordForm& password_form);
+
// Update the state of generation for this form.
+ // If |password_is_generated == false|, removes the presaved form.
dvadym 2016/04/06 12:44:23 nit: d == false| -> d| == false
kolos1 2016/04/07 13:05:18 Done.
void SetHasGeneratedPasswordForForm(
password_manager::PasswordManagerDriver* driver,
const autofill::PasswordForm& form,

Powered by Google App Engine
This is Rietveld 408576698