components/autofill/content/common/autofill_messages.h - Issue 1817483002: [Password Manager] Presave the form with generated password till successful login

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 1817483002: [Password Manager] Presave the form with generated password till successful login (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_generation_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_generation_agent.h » ('j') | components/autofill/content/renderer/password_generation_agent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index 0b2e81398c6e281e2e6aa02d575338a3d38bb161..a05b6cfcf159c8730855830fbcbf3b8ac7db7409 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -341,7 +341,16 @@ IPC_MESSAGE_ROUTED2(AutofillHostMsg_ShowPasswordEditingPopup,

// Instructs the browser to hide any password generation popups.

IPC_MESSAGE_ROUTED0(AutofillHostMsg_HidePasswordGenerationPopup)

-// Instructs the browsr that form no longer contains a generated password.

+// Instructs the browser to presave the form with generated password.

+IPC_MESSAGE_ROUTED1(AutofillHostMsg_PresaveGeneratedPassword,

dvadym 2016/04/06 12:44:23 Why do we need 2 messages? It seems that 1 is enou

kolos1 2016/04/07 13:05:18 Done.

+ autofill::PasswordForm)

+// Instructs the browser to update the presaved form with generated password.

+IPC_MESSAGE_ROUTED1(AutofillHostMsg_UpdatePresavedPassword,

+ autofill::PasswordForm)

+// Instructs the browser that form no longer contains a generated password and

+// the presaved form should be removed.

IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordNoLongerGenerated,

autofill::PasswordForm)