Always apply parent clips to selection rects when painting.

Always apply parent clips to selection rects when painting.

Previously, BoxClipper would try to avoid clipping if it appeared the clip had
no effect, by comparing with contentVisualOverflowRect().
Now that selections paint newline placeholders, the selection rect may
extend beyond the overflow rect. (Selection is not part of overflow, since it is
required for it not to affect layout.)

BUG=594962
Committed: https://crrev.com/19f335aba751a0809efa94d641502e6f72249bad
Cr-Commit-Position: refs/heads/master@{#382313}

[chrishtr, 2016-03-18 22:20:07]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
Always apply parent clips to selection rects when painting.

Previously, BoxClipper would try to avoid clipping if it appeared the clip had
no effect, by comparing with contentVisualOverflowRect().
Now that selections paint newline placeholders, the selection rect may
extend beyond the overflow rect. (Selection is not part of overflow, since it is
required for it not to affect layout.)

BUG=594962
==========

[chrishtr, 2016-03-18 22:21:22]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2016-03-18 22:29:30]

lgtm

[wkorman, 2016-03-18 22:30:19]

The CQ bit was checked by wkorman@chromium.org

[commit-bot: I haz the power, 2016-03-18 22:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817463004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817463004/40001

[wkorman, 2016-03-19 19:44:28]

The CQ bit was checked by wkorman@chromium.org

[wkorman, 2016-03-19 19:44:29]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/1817463004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-03-19 19:44:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817463004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817463004/60001

[commit-bot: I haz the power, 2016-03-19 21:09:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 21:09:43]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-03-21 15:49:05]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-03-21 15:49:06]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/1817463004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-03-21 15:49:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817463004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817463004/80001

[commit-bot: I haz the power, 2016-03-21 17:18:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-21 17:20:56]

Description was changed from

==========
Always apply parent clips to selection rects when painting.

Previously, BoxClipper would try to avoid clipping if it appeared the clip had
no effect, by comparing with contentVisualOverflowRect().
Now that selections paint newline placeholders, the selection rect may
extend beyond the overflow rect. (Selection is not part of overflow, since it is
required for it not to affect layout.)

BUG=594962
==========

to

==========
Always apply parent clips to selection rects when painting.

Previously, BoxClipper would try to avoid clipping if it appeared the clip had
no effect, by comparing with contentVisualOverflowRect().
Now that selections paint newline placeholders, the selection rect may
extend beyond the overflow rect. (Selection is not part of overflow, since it is
required for it not to affect layout.)

BUG=594962

Committed: https://crrev.com/19f335aba751a0809efa94d641502e6f72249bad
Cr-Commit-Position: refs/heads/master@{#382313}
==========

[commit-bot: I haz the power, 2016-03-21 17:20:57]

Patchset 5 (id:??) landed as
https://crrev.com/19f335aba751a0809efa94d641502e6f72249bad
Cr-Commit-Position: refs/heads/master@{#382313}

[jbroman, 2016-03-21 17:36:47]

I'm a little confused by the description here; visual overflow _doesn't_ affect
layout (layout overflow does), and exists exactly to handle purely visual
(non-layout-effecting) effects, like box-shadow.

[chrishtr, 2016-03-21 21:39:57]

On 2016/03/21 at 17:36:47, jbroman wrote:
> I'm a little confused by the description here; visual overflow _doesn't_
affect layout (layout overflow does), and exists exactly to handle purely visual
(non-layout-effecting) effects, like box-shadow.

You're right, I was wrong. It seems ideally selection should be included in
visual overflow. This may allow us to get rid of the special paint invalidation
bits and rects for it as well.