Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1817463003: Fix crash without GPU in test_plugin.cc (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
Reviewers:
pfeldman, piman
CC:
chromium-reviews, mlamouri+watch-test-runner_chromium.org, jochen+watch_chromium.org, dcheng, Ken Russell (switch to Gerrit), piman, no sievers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash without GPU in test_plugin.cc When GPU isn't available, context_ will be null. gl_ should be equally null in that case, and we should not deref the context_. R=pfeldman@chromium.org, piman@chromium.org TBR=pfeldman BUG=596147 Committed: https://crrev.com/7865b1d30daf6e4b75d8fe89768828e09b44caee Cr-Commit-Position: refs/heads/master@{#382110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/test_runner/test_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
danakj
Verified the fix with: ./out_desktop/Debug/content_shell --run-layout-test --dump-render-tree --disable-gpu ~/Downloads/fuzz-00018.html
4 years, 9 months ago (2016-03-18 20:09:40 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817463003/1
4 years, 9 months ago (2016-03-18 20:10:20 UTC) #3
piman
lgtm
4 years, 9 months ago (2016-03-18 20:21:02 UTC) #4
danakj
TBR'ing pfeldman as discussed
4 years, 9 months ago (2016-03-18 20:55:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817463003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817463003/1
4 years, 9 months ago (2016-03-18 20:56:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 22:18:51 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 22:21:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7865b1d30daf6e4b75d8fe89768828e09b44caee
Cr-Commit-Position: refs/heads/master@{#382110}

Powered by Google App Engine
This is Rietveld 408576698