Implement Event.relatedTargetScoped

Implement Event.relatedTargetScoped

This CL implements Event.relatedTargetScoped flag, which is set to false by default and should be set to true only if the event is trusted and has a related target or if the user sets it to true.
See the spec here: https://w3c.github.io/webcomponents/spec/shadow/#dfn-relatedtargetscoped-flag

BUG=589782
TBR=holte@chromium.org

Committed: https://crrev.com/19bc947948fe95fd5fae7cbe3e9a8ef71d8cf0c0
Cr-Commit-Position: refs/heads/master@{#381929}

[yuzuchan, 2016-03-18 05:20:39]

yuzus@chromium.org changed reviewers:
+ hayato@chromium.org, kochi@chromium.org

[yuzuchan, 2016-03-18 05:20:39]

PTAL

[kochi, 2016-03-18 05:43:43]

lgtm

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:213: Event(const AtomicString&
eventType, bool canBubbleArg, bool cancelableArg, EventTarget* relatedTarget,
double platformTimeStamp);
nit: s/eventType/type/, s/canBubbleArg/canBubble/, s/cancelableArg/cacnelable/ ?
Any reason why parameter names are different from other lines?

[kochi, 2016-03-18 05:44:25]

could you fix oilpan build error?

[hayato, 2016-03-18 06:26:52]

I chatted with Yuzu offline.
We'll make another CL to use relatedTargetScope so that event path is actually
affected by this properties.

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/shadow-dom/events-related-target-scoped.html
(right):

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shadow-dom/events-related-target-scoped.html:53:
async_test(function(t) {
It looks that this test is assuming that target1 is already focused and should
be run after the previous test is run.

I'd rather make each test be independent of others so that each test does not
depend on the result of other tests.

e.g.
Focus target1 in this test so that this test does not depends on the previous
test.

[yuzuchan, 2016-03-18 07:20:15]

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/shadow-dom/events-related-target-scoped.html
(right):

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shadow-dom/events-related-target-scoped.html:53:
async_test(function(t) {
On 2016/03/18 at 06:26:52, hayato wrote:
> It looks that this test is assuming that target1 is already focused and should
be run after the previous test is run.
> 
> I'd rather make each test be independent of others so that each test does not
depend on the result of other tests.
> 
> e.g.
> Focus target1 in this test so that this test does not depends on the previous
test.

Thanks for the comment, done.

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/events/Event.h (right):

https://codereview.chromium.org/1817453002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/events/Event.h:213: Event(const AtomicString&
eventType, bool canBubbleArg, bool cancelableArg, EventTarget* relatedTarget,
double platformTimeStamp);
On 2016/03/18 at 05:43:43, kochi wrote:
> nit: s/eventType/type/, s/canBubbleArg/canBubble/, s/cancelableArg/cacnelable/
?
> Any reason why parameter names are different from other lines?

Fixed.

[yuzuchan, 2016-03-18 08:01:19]

The CQ bit was checked by yuzus@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 08:01:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817453002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817453002/100001

[yuzuchan, 2016-03-18 08:05:44]

yuzus@chromium.org changed reviewers:
+ holte@chromium.org

[yuzuchan, 2016-03-18 08:06:59]

Hello holte@, could you please lgtm this CL if it looks good?
I changed histogram.xml because of the change in UseCounter.h.

Thanks!

[yuzuchan, 2016-03-18 08:09:31]

The CQ bit was unchecked by yuzus@chromium.org

[kochi, 2016-03-18 08:15:05]

On 2016/03/18 08:06:59, yuzuchan wrote:
> Hello holte@, could you please lgtm this CL if it looks good?
> I changed histogram.xml because of the change in UseCounter.h.
> 
> Thanks!

Yuzu, in this case TBR= works, as .xml file change is mechanical.
(Adding TBR=holte@chromium.org in the description).

[yuzuchan, 2016-03-18 08:21:19]

On 2016/03/18 at 08:15:05, kochi wrote:
> On 2016/03/18 08:06:59, yuzuchan wrote:
> > Hello holte@, could you please lgtm this CL if it looks good?
> > I changed histogram.xml because of the change in UseCounter.h.
> > 
> > Thanks!
> 
> Yuzu, in this case TBR= works, as .xml file change is mechanical.
> (Adding TBR=holte@chromium.org in the description).

Oh okay, thanks for letting me know :)

[hayato, 2016-03-18 08:31:03]

lgtm

[yuzuchan, 2016-03-18 08:31:47]

Description was changed from

==========
Implement Event.relatedTargetScoped

This CL implements Event.relatedTargetScoped flag, which is set to false by
default and should be set to true only if the event is trusted and has a related
target or if the user sets it to true.
See the spec here:
https://w3c.github.io/webcomponents/spec/shadow/#dfn-relatedtargetscoped-flag

BUG=589782
==========

to

==========
Implement Event.relatedTargetScoped

This CL implements Event.relatedTargetScoped flag, which is set to false by
default and should be set to true only if the event is trusted and has a related
target or if the user sets it to true.
See the spec here:
https://w3c.github.io/webcomponents/spec/shadow/#dfn-relatedtargetscoped-flag

BUG=589782
TBR=holte@chromium.org
==========

[yuzuchan, 2016-03-18 08:31:47]

yuzus@chromium.org changed reviewers:
- holte@chromium.org

[yuzuchan, 2016-03-18 09:25:51]

The CQ bit was checked by yuzus@chromium.org

[yuzuchan, 2016-03-18 09:25:51]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org,
hayato@chromium.org
Link to the patchset: https://codereview.chromium.org/1817453002/#ps120001
(title: "Fix layout test")

[commit-bot: I haz the power, 2016-03-18 09:26:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817453002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817453002/120001

[yuzuchan, 2016-03-18 09:32:58]

After this lgtm I fixed a build-bot failure by modifying a mouseover function in
layout test.

[commit-bot: I haz the power, 2016-03-18 10:55:04]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-03-18 10:56:09]

Description was changed from

==========
Implement Event.relatedTargetScoped

This CL implements Event.relatedTargetScoped flag, which is set to false by
default and should be set to true only if the event is trusted and has a related
target or if the user sets it to true.
See the spec here:
https://w3c.github.io/webcomponents/spec/shadow/#dfn-relatedtargetscoped-flag

BUG=589782
TBR=holte@chromium.org
==========

to

==========
Implement Event.relatedTargetScoped

This CL implements Event.relatedTargetScoped flag, which is set to false by
default and should be set to true only if the event is trusted and has a related
target or if the user sets it to true.
See the spec here:
https://w3c.github.io/webcomponents/spec/shadow/#dfn-relatedtargetscoped-flag

BUG=589782
TBR=holte@chromium.org

Committed: https://crrev.com/19bc947948fe95fd5fae7cbe3e9a8ef71d8cf0c0
Cr-Commit-Position: refs/heads/master@{#381929}
==========

[commit-bot: I haz the power, 2016-03-18 10:56:10]

Patchset 7 (id:??) landed as
https://crrev.com/19bc947948fe95fd5fae7cbe3e9a8ef71d8cf0c0
Cr-Commit-Position: refs/heads/master@{#381929}

[Steven Holte, 2016-03-24 19:51:39]

holte@chromium.org changed reviewers:
+ holte@chromium.org

[Steven Holte, 2016-03-24 19:51:40]

lgtm