Remove oob elements collected from the prototype chain by trimming in GetArrayKeys

Remove oob elements collected from the prototype chain by trimming in GetArrayKeys

BUG=chromium:594953
LOG=n

Committed: https://crrev.com/c6f9883d53b05b882d41dc887385636d6c7d29fe
Cr-Commit-Position: refs/heads/master@{#34893}

[Toon Verwaest, 2016-03-18 10:36:01]

verwaest@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Toon Verwaest, 2016-03-18 10:36:02]

ptal

[Jakob Kummerow, 2016-03-18 13:06:43]

LGTM, but this obviates the need for a bunch of !IS_UNDEFINED(key) checks in
array.js, right? Grepping for occurrences of %GetArrayKeys in that file, I find
such checks in SparseSlice, SparseMove, CopyFromPrototype,
ShadowPrototypeElements, InnerArrayIndexOf, InnerArrayLastIndexOf. Happy to take
another look at the CL after dropping those if you want.

[Toon Verwaest, 2016-03-18 13:54:50]

Removed those IS_UNDEFINED calls

[Jakob Kummerow, 2016-03-18 14:00:25]

LGTM

https://codereview.chromium.org/1817443003/diff/20001/src/js/array.js
File src/js/array.js (right):

https://codereview.chromium.org/1817443003/diff/20001/src/js/array.js#newcode...
src/js/array.js:1065: if (!IS_UNDEFINED(index) && !HAS_OWN_PROPERTY(obj, index)
This can go too

https://codereview.chromium.org/1817443003/diff/20001/src/js/array.js#newcode...
src/js/array.js:1093: if (!IS_UNDEFINED(index) && from <= index &&
and this too

[Toon Verwaest, 2016-03-18 14:14:55]

Done.

[Toon Verwaest, 2016-03-18 14:14:59]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-03-18 14:15:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1817443003/#ps40001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-03-18 14:15:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1817443003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1817443003/40001

[commit-bot: I haz the power, 2016-03-18 14:36:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 14:37:45]

Description was changed from

==========
Remove oob elements collected from the prototype chain by trimming in
GetArrayKeys

BUG=chromium:594953
LOG=n
==========

to

==========
Remove oob elements collected from the prototype chain by trimming in
GetArrayKeys

BUG=chromium:594953
LOG=n

Committed: https://crrev.com/c6f9883d53b05b882d41dc887385636d6c7d29fe
Cr-Commit-Position: refs/heads/master@{#34893}
==========

[commit-bot: I haz the power, 2016-03-18 14:37:46]

Patchset 3 (id:??) landed as
https://crrev.com/c6f9883d53b05b882d41dc887385636d6c7d29fe
Cr-Commit-Position: refs/heads/master@{#34893}