Test running changes.

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 41bdf2feae1fa188abf5f98a6eb426db77523db4..077e58f765dc88b16e25ee6f5df7a58f3860dbeb 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1517,7 +1517,7 @@ class StandardTestSuite extends TestSuite {
       "packageRoot": null,
       "hasCompileError": hasCompileError,
       "hasRuntimeError": hasRuntimeError,
-      "isStaticClean" : !hasStaticWarning,
+      "isStaticClean" : !hasCompileError && !hasStaticWarning,

[kustermann, 2013/07/01 11:58:38]

If I look into test_runner.dart:AnalysisCommandOutputImpl:_didStandardTestFail:
The 'isStaticClean' flag is only used in terms of warnings:
So the change you made has no effect. Or do I miss something?

[Side Note:

If I understand this correctly, we expect all co19 tests to be free of analyzer
warnings/errors except the ones which have @compile-error/@static-warning
annotations.

I don't know if our agreement with the co19 team guarantees that or not.
Here's is what I think:

*Some* co19 tests will test that the analyzer outputs a warning/error in certain
cases.

*Other* co19 tests will test the libraries and I don't know if we expect them to
be free of warnings (they're after all testing library functionality not
analyzer warnings).]

[scheglov, 2013/07/02 21:19:42]

  "isStaticClean" is IMHO exactly what it says - it should be clean; has no any
problems - errors or warnings - no matter.
  I think so.
  My impression is that co19 team aims to have only legitimate warnings, which
are supposed to be tested and don't have any extra/random warnings.

       "otherScripts": <String>[],
       "isMultitest": isMultitest,
       "isMultiHtmlTest": false,