tools/testing/dart/test_runner.dart - Issue 18174010: Test running changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_runner.dart

Issue 18174010: Test running changes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/test_runner.dart

diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart

index 1cae1d7773c8e79629eb85a3e4fb0b962accf879..ceb053c1a3c8921ad10fd3d38adeacbe969a42b1 100644

--- a/tools/testing/dart/test_runner.dart

+++ b/tools/testing/dart/test_runner.dart

@@ -848,11 +848,7 @@ class AnalysisCommandOutputImpl extends CommandOutputImpl {

if (fields[ERROR_LEVEL] == 'ERROR') {

errors.add(fields[FORMATTED_ERROR]);

} else if (fields[ERROR_LEVEL] == 'WARNING') {

- // We only care about testing Static type warnings

- // ignore all others

- if (fields[ERROR_TYPE] == 'STATIC_TYPE' || fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {

- staticWarnings.add(fields[FORMATTED_ERROR]);

- }

+ staticWarnings.add(fields[FORMATTED_ERROR]);

}

// OK to Skip error output that doesn't match the machine format

}