Test running changes.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 1499 matching lines @@
       stderr.writeln(
           "Warning: deprecated @dynamic-type-error tag used in $filePath");
     }
 
     return {
       "vmOptions": <List>[[]],
       "dartOptions": null,
       "packageRoot": null,
       "hasCompileError": hasCompileError,
       "hasRuntimeError": hasRuntimeError,
-      "isStaticClean" : !hasStaticWarning,
+      "isStaticClean" : !hasCompileError && !hasStaticWarning,

[kustermann, 2013/07/01 11:58:38]

If I look into test_runner.dart:AnalysisCommandOutputImpl:_didStandardTestFail:
The 'isStaticClean' flag is only used in terms of warnings:
So the change you made has no effect. Or do I miss something?

[Side Note:

If I understand this correctly, we expect all co19 tests to be free of analyzer
warnings/errors except the ones which have @compile-error/@static-warning
annotations.

I don't know if our agreement with the co19 team guarantees that or not.
Here's is what I think:

*Some* co19 tests will test that the analyzer outputs a warning/error in certain
cases.

*Other* co19 tests will test the libraries and I don't know if we expect them to
be free of warnings (they're after all testing library functionality not
analyzer warnings).]

[scheglov, 2013/07/02 21:19:42]

  "isStaticClean" is IMHO exactly what it says - it should be clean; has no any
problems - errors or warnings - no matter.
  I think so.
  My impression is that co19 team aims to have only legitimate warnings, which
are supposed to be tested and don't have any extra/random warnings.

       "otherScripts": <String>[],
       "isMultitest": isMultitest,
       "isMultiHtmlTest": false,
       "subtestNames": <String>[],
       "isolateStubs": '',
       "containsDomImport": false,
       "numStaticTypeAnnotations": 0,
       "numCompileTimeAnnotations": 0,
     };
   }
@@ skipping 434 matching lines @@
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
    }
 }