Test running changes.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 830 matching lines @@
     List<String> staticWarnings = [];
 
     // Read the returned list of errors and stuff them away.
     var stderrLines = decodeUtf8(super.stderr).split("\n");
     for (String line in stderrLines) {
       if (line.length == 0) continue;
       List<String> fields = splitMachineError(line);
       if (fields[ERROR_LEVEL] == 'ERROR') {
         errors.add(fields[FORMATTED_ERROR]);
       } else if (fields[ERROR_LEVEL] == 'WARNING') {
-        // We only care about testing Static type warnings
-        // ignore all others
-        if (fields[ERROR_TYPE] == 'STATIC_TYPE' || fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {
-          staticWarnings.add(fields[FORMATTED_ERROR]);
-        }
+        staticWarnings.add(fields[FORMATTED_ERROR]);
       }
       // OK to Skip error output that doesn't match the machine format
     }
     if (testCase.info != null
         && testCase.info.optionsFromFile['isMultitest']) {
       return _didMultitestFail(errors, staticWarnings);
     }
     return _didStandardTestFail(errors, staticWarnings);
   }
 
   bool _didMultitestFail(List errors, List staticWarnings) {
     Set<String> outcome = testCase.info.multitestOutcome;
     if (outcome == null) throw "outcome must not be null";
     if (outcome.contains('compile-time error') && errors.length > 0) {
       return true;
     } else if (outcome.contains('static type warning')
         && staticWarnings.length > 0) {
       return true;
     } else if (outcome.isEmpty
         && (errors.length > 0 || staticWarnings.length > 0)) {
       return true;
     }
     return false;
   }
 
   bool _didStandardTestFail(List errors, List staticWarnings) {
     bool hasFatalTypeErrors = false;

[kustermann, 2013/07/01 11:58:38]

I wouldn't be surprised if this complex logic down here has some issues as well.

     int numStaticTypeAnnotations = 0;
     int numCompileTimeAnnotations = 0;
     var isStaticClean = false;
     if (testCase.info != null) {
       var optionsFromFile = testCase.info.optionsFromFile;
       hasFatalTypeErrors = testCase.info.hasFatalTypeErrors;
       for (Command c in testCase.commands) {
         for (String arg in c.arguments) {
           if (arg == '--fatal-type-errors') {
             hasFatalTypeErrors = true;
@@ skipping 23 matching lines @@
     if (numStaticTypeAnnotations > 0 && isStaticClean) {
       diagnostics.add("Cannot have both @static-clean and /// static "
                       "type warning annotations.");
       return true;
     }
 
     if (isStaticClean && staticWarnings.length > 0) {
       diagnostics.add(
           "@static-clean annotation found but analyzer returned warnings.");
       return true;
     }

[kustermann, 2013/07/01 11:58:38]

With your second change, you may want to change this to:
if (isStaticClean &&
    (errors.length > 0 || (staticWarnings.length > 0)) {
  // ...
  return true;
}

[scheglov, 2013/07/02 21:19:42]

There is check for errors below, but it is done without message.
I've added this check for warnings here and also generalized message, because it
is not just warnings now.

 
     if (numCompileTimeAnnotations > 0
         && numCompileTimeAnnotations < errors.length) {
       // Expected compile-time errors were not returned.
       // The test did not 'fail' in the way intended so don't return failed.
       diagnostics.add("Fewer compile time errors than annotated: "
           "$numCompileTimeAnnotations");
       return false;
     }
 
@@ skipping 976 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
   }
 }