Test running changes.

tools/testing/dart/test_runner.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for executing tests.
  *
  * This module includes:
  * - Managing parallel execution of tests, including timeout checks.
  * - Evaluating the output of each test as pass/fail/crash/timeout.
@@ skipping 830 matching lines @@
     List<String> staticWarnings = [];
 
     // Read the returned list of errors and stuff them away.
     var stderrLines = decodeUtf8(super.stderr).split("\n");
     for (String line in stderrLines) {
       if (line.length == 0) continue;
       List<String> fields = splitMachineError(line);
       if (fields[ERROR_LEVEL] == 'ERROR') {
         errors.add(fields[FORMATTED_ERROR]);
       } else if (fields[ERROR_LEVEL] == 'WARNING') {
-        // We only care about testing Static type warnings
-        // ignore all others
-        if (fields[ERROR_TYPE] == 'STATIC_TYPE' || fields[ERROR_TYPE] == 'STATIC_TYPE_WARNING') {
-          staticWarnings.add(fields[FORMATTED_ERROR]);
-        }
+        staticWarnings.add(fields[FORMATTED_ERROR]);
       }
       // OK to Skip error output that doesn't match the machine format
     }
     if (testCase.info != null
         && testCase.info.optionsFromFile['isMultitest']) {
       return _didMultitestFail(errors, staticWarnings);
     }
     return _didStandardTestFail(errors, staticWarnings);
   }
 
@@ skipping 46 matching lines @@
       diagnostics.add("  command[0]:${testCase.commands[0]}");
       diagnostics.add("  exitCode:${exitCode}");
       return true;
     }
     if (numStaticTypeAnnotations > 0 && isStaticClean) {
       diagnostics.add("Cannot have both @static-clean and /// static "
                       "type warning annotations.");
       return true;
     }
 
-    if (isStaticClean && staticWarnings.length > 0) {
+    if (isStaticClean && (errors.isNotEmpty || staticWarnings.isNotEmpty)) {
       diagnostics.add(
-          "@static-clean annotation found but analyzer returned warnings.");
+          "@static-clean annotation found but analyzer returned problems.");
       return true;
     }
 
     if (numCompileTimeAnnotations > 0
         && numCompileTimeAnnotations < errors.length) {
       // Expected compile-time errors were not returned.
       // The test did not 'fail' in the way intended so don't return failed.
       diagnostics.add("Fewer compile time errors than annotated: "
           "$numCompileTimeAnnotations");
       return false;
@@ skipping 989 matching lines @@
     }
   }
 
   void eventAllTestsDone() {
     for (var listener in _eventListener) {
       listener.allDone();
     }
   }
 }