src/image/SkImage_Generator.cpp - Issue 1817383002: switch surface to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/image/SkImage_Generator.cpp

Issue 1817383002: switch surface to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/image/SkImage_Generator.cpp

diff --git a/src/image/SkImage_Generator.cpp b/src/image/SkImage_Generator.cpp

index f8af12a612d22272935fc884196d4c6e01bd63ad..44dd7b11f83b8dfaff8d37a35a2e48c0d1201a09 100644

--- a/src/image/SkImage_Generator.cpp

+++ b/src/image/SkImage_Generator.cpp

@@ -79,7 +79,7 @@ sk_sp<SkImage> SkImage_Generator::onMakeSubset(const SkIRect& subset) const {

const SkImageInfo info = SkImageInfo::MakeN32(subset.width(), subset.height(),

this->isOpaque() ? kOpaque_SkAlphaType : kPremul_SkAlphaType);

- SkAutoTUnref<SkSurface> surface(SkSurface::NewRaster(info));

+ auto surface(SkSurface::MakeRaster(info));

if (!surface) {

return nullptr;

}