Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1817353002: Fix input frames being dropped when the h.264 DXVA decoder detects a configuration change. (Closed)

Created:
4 years, 9 months ago by ananta
Modified:
4 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix input frames being dropped when the h.264 DXVA decoder detects a configuration change. The patch to detect a mid stream configuration change and reinitialize the decoder introduced a bug while processing stream changes, where in input frames coming in for decoding while processing the configuration change were dropped causing the video to jitter or not display correctly. Fix is to not drop the input frames when we are processing a configuration change and instead add the input frames to the pending input list which is processed after the configuration change is completed. To detect a configuration change, we enter a new state kConfigChange which then resets back to kNormal after initialization. BUG=594266 Committed: https://crrev.com/c14bd2e1f69db8316fac39eb8e71b9103f0dd223 Cr-Commit-Position: refs/heads/master@{#382475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M content/common/gpu/media/dxva_video_decode_accelerator_win.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/dxva_video_decode_accelerator_win.cc View 3 chunks +10 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
ananta
4 years, 9 months ago (2016-03-22 00:50:03 UTC) #2
sandersd (OOO until July 31)
lgtm
4 years, 9 months ago (2016-03-22 01:03:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1817353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1817353002/1
4 years, 9 months ago (2016-03-22 01:08:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-22 02:14:57 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 02:16:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c14bd2e1f69db8316fac39eb8e71b9103f0dd223
Cr-Commit-Position: refs/heads/master@{#382475}

Powered by Google App Engine
This is Rietveld 408576698